diff --git a/Library/Homebrew/.rubocop-rspec.yml b/Library/Homebrew/.rubocop-rspec.yml deleted file mode 100644 index 0aac8fc3e2..0000000000 --- a/Library/Homebrew/.rubocop-rspec.yml +++ /dev/null @@ -1,6 +0,0 @@ -inherit_from: - - .rubocop.yml - -RSpec/ExpectActual: - Exclude: - - 'test/missing_formula_spec.rb' diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index da003e380b..22d0d1ec49 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -1,5 +1,6 @@ inherit_from: - ../.rubocop.yml + - .rubocop_todo.yml AllCops: Include: diff --git a/Library/Homebrew/.rubocop_todo.yml b/Library/Homebrew/.rubocop_todo.yml new file mode 100644 index 0000000000..ac9e850a82 --- /dev/null +++ b/Library/Homebrew/.rubocop_todo.yml @@ -0,0 +1,141 @@ +# This configuration was generated by +# `rubocop --auto-gen-config` +# on 2018-09-20 09:03:52 +0100 using RuboCop version 0.59.1. +# The point is for the user to remove these configuration records +# one by one as the offenses are removed from the code base. +# Note that changes in the inspected code, or installation of new +# versions of RuboCop, may require this file to be generated again. + +# Offense count: 1 +# Cop supports --auto-correct. +Layout/LeadingCommentSpace: + Exclude: + - 'style.rb' + +# Offense count: 27 +RSpec/AnyInstance: + Exclude: + - 'test/cask/cmd/create_spec.rb' + - 'test/cask/cmd/edit_spec.rb' + - 'test/cask/cmd/outdated_spec.rb' + - 'test/cask/cmd/upgrade_spec.rb' + - 'test/caveats_spec.rb' + - 'test/cleanup_spec.rb' + - 'test/download_strategies_spec.rb' + - 'test/formatter_spec.rb' + - 'test/os/linux/dependency_collector_spec.rb' + - 'test/utils/analytics_spec.rb' + - 'test/utils/git_spec.rb' + +# Offense count: 139 +# Configuration parameters: Prefixes. +# Prefixes: when, with, without +RSpec/ContextWording: + Enabled: false + +# Offense count: 69 +RSpec/DescribeClass: + Enabled: false + +# Offense count: 573 +# Configuration parameters: Max. +RSpec/ExampleLength: + Max: 133 + +# Offense count: 16 +RSpec/ExpectActual: + Exclude: + - 'spec/routing/**/*' + - 'test/missing_formula_spec.rb' + +# Offense count: 21 +RSpec/ExpectInHook: + Exclude: + - 'test/cache_store_spec.rb' + - 'test/cask/audit_spec.rb' + - 'test/cmd/reinstall_spec.rb' + - 'test/download_strategies_spec.rb' + - 'test/linkage_cache_store_spec.rb' + - 'test/migrator_spec.rb' + - 'test/os/mac/java_requirement_spec.rb' + +# Offense count: 32 +# Configuration parameters: CustomTransform, IgnoreMethods. +RSpec/FilePath: + Enabled: false + +# Offense count: 6 +# Configuration parameters: AssignmentOnly. +RSpec/InstanceVariable: + Exclude: + - 'test/download_strategies_spec.rb' + - 'test/support/helper/spec/shared_context/integration_test.rb' + - 'test/utils/git_spec.rb' + - 'test/version_spec.rb' + +# Offense count: 113 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: have_received, receive +RSpec/MessageSpies: + Enabled: false + +# Offense count: 1 +RSpec/MissingExampleGroupArgument: + Exclude: + - 'test/cask/depends_on_spec.rb' + +# Offense count: 23 +RSpec/MultipleDescribes: + Enabled: false + +# Offense count: 544 +# Configuration parameters: AggregateFailuresByDefault. +RSpec/MultipleExpectations: + Max: 26 + +# Offense count: 929 +RSpec/NamedSubject: + Enabled: false + +# Offense count: 99 +RSpec/NestedGroups: + Max: 5 + +# Offense count: 11 +RSpec/RepeatedDescription: + Exclude: + - 'test/inreplace_spec.rb' + - 'test/migrator_spec.rb' + - 'test/rubocops/dependency_order_cop_spec.rb' + - 'test/rubocops/lines_cop_spec.rb' + - 'test/tab_spec.rb' + +# Offense count: 10 +RSpec/RepeatedExample: + Exclude: + - 'test/compiler_selector_spec.rb' + - 'test/utils/shell_spec.rb' + +# Offense count: 31 +RSpec/SubjectStub: + Exclude: + - 'test/cache_store_spec.rb' + - 'test/cmd/update-report/reporter_spec.rb' + - 'test/download_strategies_spec.rb' + - 'test/formula_installer_spec.rb' + - 'test/java_requirement_spec.rb' + - 'test/language/python_spec.rb' + - 'test/os/mac/java_requirement_spec.rb' + +# Offense count: 64 +# Configuration parameters: IgnoreSymbolicNames. +RSpec/VerifiedDoubles: + Enabled: false + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: empty, nil, both +Style/EmptyElse: + Exclude: + - 'style.rb'