admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

pull: fix false positives for nonstandard bump subjects when untapped

Browse Source 
If the formula's tap isn't tapped yet when running `brew pull`, a false
positive occurs for the nonstandard bump subject check, and a bogus
warning is printed, which claims the bump subject should refer to the
old version not the new version.
This commit is contained in:
ilovezfs 2017-02-08 00:58:20 -08:00
parent bef2c6c9bd
commit 79280826f5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/dev-cmd/pull.rb
View File

@ -376,7 +376,7 @@ module Homebrew
subject_strs << "remove stable" subject_strs << "remove stable"
formula_name_str += ":" # just for cosmetics formula_name_str += ":" # just for cosmetics
else else
subject_strs << formula.version.to_s subject_strs << new[:stable]
end end
end end
if old[:devel] != new[:devel] if old[:devel] != new[:devel]
@ -387,7 +387,7 @@ module Homebrew
formula_name_str += ":" # just for cosmetics formula_name_str += ":" # just for cosmetics
end end
else else
subject_strs << "#{formula.devel.version} (devel)" subject_strs << "#{new[:devel]} (devel)"
end end
end end
subject = subject_strs.empty? ? nil : "#{formula_name_str} #{subject_strs.join(", ")}" subject = subject_strs.empty? ? nil : "#{formula_name_str} #{subject_strs.join(", ")}"