admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

env_config: deprecate setting boolean vars to falsy values

Browse Source 
The way we handle boolean environment variables is a bit unfortunate.
For example, setting `HOMEBREW_EVAL_ALL=false` actually enables
`HOMEBREW_EVAL_ALL`.

Let's fix this by deprecating setting boolean environment variables to
common false-y values (`false`, `0`, `nil`, `no`, and `off`) so that we
can later ignore these false-y values when reading boolean environment
variables.
This commit is contained in:
Carlo Cabrera 2024-09-25 16:54:59 +08:00
parent 94416e82f0
commit 78065c5781
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/env_config.rb
View File

@ -515,7 +515,18 @@ module Homebrew
if hash[:boolean]
define_method(method_name) do
ENV[env].present?
env_value = ENV.fetch(env, nil)
falsy_values = %w[false no off nil 0]
if falsy_values.include?(env_value&.downcase)
odeprecated "#{env}=#{env_value}", <<~EOS
If you wish to enable #{env}, #{env}=1
If you wish to disable #{env}, #{env}=
EOS
end
# TODO: Uncomment the remaining part of the line below after the deprecation/disable cycle.
env_value.present? # && !falsy_values.include(env_value.downcase)
end
elsif hash[:default].present?
define_method(method_name) do

4
Library/Homebrew/test/github_runner_matrix_spec.rb
View File

@ -9,6 +9,10 @@ RSpec.describe GitHubRunnerMatrix do
allow(ENV).to receive(:fetch).with("HOMEBREW_MACOS_LONG_TIMEOUT", "false").and_return("false")
allow(ENV).to receive(:fetch).with("HOMEBREW_MACOS_BUILD_ON_GITHUB_RUNNER", "false").and_return("false")
allow(ENV).to receive(:fetch).with("GITHUB_RUN_ID").and_return("12345")
allow(ENV).to receive(:fetch).with("HOMEBREW_NO_INSTALL_FROM_API", nil).and_call_original
allow(ENV).to receive(:fetch).with("HOMEBREW_EVAL_ALL", nil).and_call_original
allow(ENV).to receive(:fetch).with("HOMEBREW_SIMULATE_MACOS_ON_LINUX", nil).and_call_original
allow(ENV).to receive(:fetch).with("HOMEBREW_FORBID_PACKAGES_FROM_PATHS", nil).and_call_original
end
let(:newest_supported_macos) do