admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #3293 from DomT4/predicate_audit

Browse Source 
audit: more *_predicate nudging/tweaks
This commit is contained in:
Mike McQuaid 2017-10-17 21:12:21 +01:00 committed by GitHub
commit 77f3fcf254
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/dev-cmd/audit.rb
View File

@ -974,8 +974,12 @@ class FormulaAuditor
problem "Use `assert_predicate <path_to_file>, :exist?` instead of `#{Regexp.last_match(1)}`" problem "Use `assert_predicate <path_to_file>, :exist?` instead of `#{Regexp.last_match(1)}`"
end end
if line =~ /assert !File\.exist\?/ if line =~ /(assert !File\.exist\?|assert !\(.*\)\.exist\?)/
problem "Use `refute_predicate <path_to_file>, :exist?` instead of `assert !File.exist?`" problem "Use `refute_predicate <path_to_file>, :exist?` instead of `#{Regexp.last_match(1)}`"
end
if line =~ /(assert File\.executable\?|assert \(.*\)\.executable\?)/
problem "Use `assert_predicate <path_to_file>, :executable?` instead of `#{Regexp.last_match(1)}`"
end end
return unless @strict return unless @strict