Merge pull request #8931 from jonchang/fix-bottling

Fix type signature of StringInreplaceExtension
This commit is contained in:
Jonathan Chang 2020-10-16 01:56:56 +11:00 committed by GitHub
commit 77be2c8a56
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -18,7 +18,7 @@ class StringInreplaceExtension
# Same as `String#sub!`, but warns if nothing was replaced.
#
# @api public
sig { params(before: String, after: String).returns(T.nilable(String)) }
sig { params(before: T.any(Regexp, String), after: String).returns(T.nilable(String)) }
def sub!(before, after)
result = inreplace_string.sub!(before, after)
errors << "expected replacement of #{before.inspect} with #{after.inspect}" unless result