admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #14596 from cho-m/livecheck-no-colon

Browse Source 
livecheck_version: only split on commas in cask version
This commit is contained in:
Mike McQuaid 2023-02-13 14:59:29 +00:00 committed by GitHub
commit 77bcf65e88
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/livecheck/livecheck_version.rb
View File

@ -19,7 +19,7 @@ module Homebrew
when Formula, Resource when Formula, Resource
[version] [version]
when Cask::Cask when Cask::Cask
version.to_s.split(/[,:]/).map { |s| Version.new(s) } version.to_s.split(",").map { |s| Version.new(s) }
else else
T.absurd(package_or_resource) T.absurd(package_or_resource)
end end

4
Library/Homebrew/test/livecheck/livecheck_version_spec.rb
View File

@ -21,20 +21,16 @@ describe Homebrew::Livecheck::LivecheckVersion do
specify "::create" do specify "::create" do
expect(described_class.create(formula, Version.new("1.1.6")).versions).to eq ["1.1.6"] expect(described_class.create(formula, Version.new("1.1.6")).versions).to eq ["1.1.6"]
expect(described_class.create(formula, Version.new("2.19.0,1.8.0")).versions).to eq ["2.19.0,1.8.0"] expect(described_class.create(formula, Version.new("2.19.0,1.8.0")).versions).to eq ["2.19.0,1.8.0"]
expect(described_class.create(formula, Version.new("1.0,100:1426778671")).versions).to eq ["1.0,100:1426778671"]
expect(described_class.create(formula, Version.new("0.17.0,20210111183933,226")).versions) expect(described_class.create(formula, Version.new("0.17.0,20210111183933,226")).versions)
.to eq ["0.17.0,20210111183933,226"] .to eq ["0.17.0,20210111183933,226"]
expect(described_class.create(cask, Version.new("1.1.6")).versions).to eq ["1.1.6"] expect(described_class.create(cask, Version.new("1.1.6")).versions).to eq ["1.1.6"]
expect(described_class.create(cask, Version.new("2.19.0,1.8.0")).versions).to eq ["2.19.0", "1.8.0"] expect(described_class.create(cask, Version.new("2.19.0,1.8.0")).versions).to eq ["2.19.0", "1.8.0"]
expect(described_class.create(cask, Version.new("1.0,100:1426778671")).versions)
.to eq ["1.0", "100", "1426778671"]
expect(described_class.create(cask, Version.new("0.17.0,20210111183933,226")).versions) expect(described_class.create(cask, Version.new("0.17.0,20210111183933,226")).versions)
.to eq ["0.17.0", "20210111183933", "226"] .to eq ["0.17.0", "20210111183933", "226"]
expect(described_class.create(resource, Version.new("1.1.6")).versions).to eq ["1.1.6"] expect(described_class.create(resource, Version.new("1.1.6")).versions).to eq ["1.1.6"]
expect(described_class.create(resource, Version.new("2.19.0,1.8.0")).versions).to eq ["2.19.0,1.8.0"] expect(described_class.create(resource, Version.new("2.19.0,1.8.0")).versions).to eq ["2.19.0,1.8.0"]
expect(described_class.create(resource, Version.new("1.0,100:1426778671")).versions).to eq ["1.0,100:1426778671"]
expect(described_class.create(resource, Version.new("0.17.0,20210111183933,226")).versions) expect(described_class.create(resource, Version.new("0.17.0,20210111183933,226")).versions)
.to eq ["0.17.0,20210111183933,226"] .to eq ["0.17.0,20210111183933,226"]
end end