From 767ebe6ab602fd5b99f494a8ad82c19d7747639e Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Sat, 9 Jun 2018 11:19:04 +0200 Subject: [PATCH] Fail `brew cask upgrade` early if Cask is not installed. --- Library/Homebrew/cask/lib/hbc/cli/upgrade.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb b/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb index 276b180aa1..e0589eb0d0 100644 --- a/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb +++ b/Library/Homebrew/cask/lib/hbc/cli/upgrade.rb @@ -16,7 +16,10 @@ module Hbc Caskroom.casks.select do |cask| cask.outdated?(greedy?) end - }).select { |cask| cask.outdated?(true) } + }).select do |cask| + raise CaskNotInstalledError, cask unless cask.installed? || force? + cask.outdated?(true) + end if outdated_casks.empty? oh1 "No Casks to upgrade" @@ -28,8 +31,6 @@ module Hbc outdated_casks.each do |old_cask| odebug "Started upgrade process for Cask #{old_cask}" - raise CaskNotInstalledError, old_cask unless old_cask.installed? || force? - raise CaskUnavailableError.new(old_cask, "The Caskfile is missing!") if old_cask.installed_caskfile.nil? old_cask = CaskLoader.load(old_cask.installed_caskfile)