brew.sh: add bump to HOMEBREW_NO_INSTALL_FROM_API commands

`brew bump` relies on `livecheck`, which we don't want to query the API
for.

Also, some small refactoring:

1. Declare the list of commands we want to set
   `HOMEBREW_NO_INSTALL_FROM_API` for as an array.
2. Only check against this list when the command being run is a
   developer command, to avoid checking the list when we know we're not
   running a dev command.
This commit is contained in:
Carlo Cabrera 2023-02-07 14:33:33 +08:00
parent 2bb5cdaaa9
commit 76466f66d2
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0

View File

@ -755,6 +755,33 @@ if [[ -f "${HOMEBREW_LIBRARY}/Homebrew/dev-cmd/${HOMEBREW_COMMAND}.sh" ]] ||
[[ -f "${HOMEBREW_LIBRARY}/Homebrew/dev-cmd/${HOMEBREW_COMMAND}.rb" ]] [[ -f "${HOMEBREW_LIBRARY}/Homebrew/dev-cmd/${HOMEBREW_COMMAND}.rb" ]]
then then
export HOMEBREW_DEVELOPER_COMMAND="1" export HOMEBREW_DEVELOPER_COMMAND="1"
NO_INSTALL_FROM_API_COMMANDS=(
audit
bottle
bump-cask-pr
bump-formula-pr
bump-revision
bump-unversioned-casks
bump
cat
create
edit
extract
formula
livecheck
pr-pull
pr-upload
test
update-python-resources
)
if [[ " ${NO_INSTALL_FROM_API_COMMANDS[*]} " == *" ${HOMEBREW_COMMAND} "* ]]
then
export HOMEBREW_NO_INSTALL_FROM_API=1
fi
unset NO_INSTALL_FROM_API_COMMANDS
fi fi
if [[ -n "${HOMEBREW_DEVELOPER_COMMAND}" && -z "${HOMEBREW_DEVELOPER}" ]] if [[ -n "${HOMEBREW_DEVELOPER_COMMAND}" && -z "${HOMEBREW_DEVELOPER}" ]]
@ -772,26 +799,6 @@ To turn developer mode off, run $(bold "brew developer off")
export HOMEBREW_DEV_CMD_RUN="1" export HOMEBREW_DEV_CMD_RUN="1"
fi fi
if [[ "${HOMEBREW_COMMAND}" == "audit" ]] ||
[[ "${HOMEBREW_COMMAND}" == "bottle" ]] ||
[[ "${HOMEBREW_COMMAND}" == "bump-cask-pr" ]] ||
[[ "${HOMEBREW_COMMAND}" == "bump-formula-pr" ]] ||
[[ "${HOMEBREW_COMMAND}" == "bump-revision" ]] ||
[[ "${HOMEBREW_COMMAND}" == "bump-unversioned-casks" ]] ||
[[ "${HOMEBREW_COMMAND}" == "cat" ]] ||
[[ "${HOMEBREW_COMMAND}" == "create" ]] ||
[[ "${HOMEBREW_COMMAND}" == "edit" ]] ||
[[ "${HOMEBREW_COMMAND}" == "extract" ]] ||
[[ "${HOMEBREW_COMMAND}" == "formula" ]] ||
[[ "${HOMEBREW_COMMAND}" == "livecheck" ]] ||
[[ "${HOMEBREW_COMMAND}" == "pr-pull" ]] ||
[[ "${HOMEBREW_COMMAND}" == "pr-upload" ]] ||
[[ "${HOMEBREW_COMMAND}" == "test" ]] ||
[[ "${HOMEBREW_COMMAND}" == "update-python-resources" ]]
then
export HOMEBREW_NO_INSTALL_FROM_API=1
fi
if [[ -f "${HOMEBREW_LIBRARY}/Homebrew/cmd/${HOMEBREW_COMMAND}.sh" ]] if [[ -f "${HOMEBREW_LIBRARY}/Homebrew/cmd/${HOMEBREW_COMMAND}.sh" ]]
then then
HOMEBREW_BASH_COMMAND="${HOMEBREW_LIBRARY}/Homebrew/cmd/${HOMEBREW_COMMAND}.sh" HOMEBREW_BASH_COMMAND="${HOMEBREW_LIBRARY}/Homebrew/cmd/${HOMEBREW_COMMAND}.sh"