admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Version: Improve date version parsing

Browse Source 
The existing date version parsing regex only matches file names that
have a prefix (e.g., `ltopers-v2017-04-14.tar.gz`), so it doesn't
match files like `2023-09-28.tar.gz`. There are a handful of formulae
that have to manually specify the version as a result (e.g.,
`marksman`, `sqtop`, etc.). `bootloadhid` is also affected but that's
because the filename uses a dot as the prefix delimiter (e.g.,
`bootloadHID.2012-12-08.tar.gz`) and the regex only matches a hyphen.

This addresses these shortcomings by using `[._-]` as the prefix
delimiter and making it optional.
This commit is contained in:
Sam Ford 2023-10-04 11:58:25 -04:00
parent 75b18b5afe
commit 7626bdd1fd
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/version.rb
View File

@ -376,8 +376,9 @@ class Version
VERSION_PARSERS = [ VERSION_PARSERS = [
# date-based versioning # date-based versioning
# e.g. 2023-09-28.tar.gz
# e.g. ltopers-v2017-04-14.tar.gz # e.g. ltopers-v2017-04-14.tar.gz
StemParser.new(/-v?(\d{4}-\d{2}-\d{2})/), StemParser.new(/[._-]?v?(\d{4}-\d{2}-\d{2})/),
# GitHub tarballs # GitHub tarballs
# e.g. https://github.com/foo/bar/tarball/v1.2.3 # e.g. https://github.com/foo/bar/tarball/v1.2.3