admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add "fails_with_llvm" to formula to document LLVM build breaks.

Browse Source 
Replaced ENV.gcc_4_2 + comments with calls to "fails_with_llvm",
to specifically message to the user when a formula is known or suspected
to not build with LLVM. If the user specifies "--use-llvm", the message
will be displayed, but compilation will be tried anyway.

Since using LLVM is now an advanced/hidden feature instead of the
default on 10.6, we'll let the user try anyway (and submit patches
if things are now working.)
This commit is contained in:
Adam Vandenberg 2010-06-16 11:50:36 -07:00
parent 9638c1820a
commit 76168e8e87
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Library/Homebrew/formula.rb
View File

@ -296,6 +296,17 @@ class Formula
self.class.external_deps self.class.external_deps
end end
def fails_with_llvm msg="", data=nil
return unless (ENV['HOMEBREW_USE_LLVM'] or ARGV.include? '--use-llvm')
build = data.delete :build rescue nil
msg = "(No specific reason was given)" if msg.empty?
opoo "LLVM was requested, but this formula is reported as not working with LLVM:"
puts msg
puts "Tested with LLVM build #{build}" unless build == nil
end
protected protected
# Pretty titles the command and buffers stdout/stderr # Pretty titles the command and buffers stdout/stderr
# Throws if there's an error # Throws if there's an error