admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #2627 from MikeMcQuaid/audit-fix-option-detection

Browse Source 
audit: fix dependency option detection.
This commit is contained in:
Mike McQuaid 2017-05-14 15:09:07 +01:00 committed by GitHub
commit 75d230318a
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/dev-cmd/audit.rb
View File

@ -1052,8 +1052,12 @@ class FormulaAuditor
problem "#{$2} modules should be vendored rather than use deprecated `depends_on \"#{$1}\" => :#{$2}#{$3}`" problem "#{$2} modules should be vendored rather than use deprecated `depends_on \"#{$1}\" => :#{$2}#{$3}`"
end end
if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+.*(?<!\?[( ])['"](.+)['"]/ if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+(.*)/
problem "Dependency #{$1} should not use option #{$2}" dep = $1
$2.split(" ").map do |o|
next unless o =~ /^\[?['"](.*)['"]/
problem "Dependency #{dep} should not use option #{$1}"
end
end end
# Commented-out depends_on # Commented-out depends_on