admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Cache and reuse Dependency objects

Browse Source
This commit is contained in:
Jack Nagel 2014-02-27 14:22:43 -06:00
parent 1981e78eb2
commit 74eb25df81
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Library/Homebrew/dependency_collector.rb
View File

@ -21,6 +21,8 @@ class DependencyCollector
:chicken, :jruby, :lua, :node, :ocaml, :perl, :python, :rbx, :ruby :chicken, :jruby, :lua, :node, :ocaml, :perl, :python, :rbx, :ruby
].freeze ].freeze
CACHE = {}
attr_reader :deps, :requirements attr_reader :deps, :requirements
def initialize def initialize
@ -29,7 +31,7 @@ class DependencyCollector
end end
def add(spec) def add(spec)
case dep = build(spec) case dep = fetch(spec)
when Dependency when Dependency
@deps << dep @deps << dep
when Requirement when Requirement
@ -38,6 +40,18 @@ class DependencyCollector
dep dep
end end
def fetch(spec)
CACHE.fetch(cache_key(spec)) { |key| CACHE[key] = build(spec) }
end
def cache_key(spec)
if Resource === spec && spec.download_strategy == CurlDownloadStrategy
File.extname(spec.url)
else
spec
end
end
def build(spec) def build(spec)
spec, tags = case spec spec, tags = case spec
when Hash then destructure_spec_hash(spec) when Hash then destructure_spec_hash(spec)