From 74207f71e61a59be797f6139db5bcc8e73f7310c Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Wed, 5 Oct 2011 23:50:29 -0500 Subject: [PATCH] cleaner: correctly obey HOMEBREW_KEEP_INFO The advertised default is that anything in share/info is removed unless the user sets HOMEBREW_KEEP_INFO, but we've actually been installing the files *unless* the variable is set. To illustrate: $ unset HOMEBREW_KEEP_INFO $ brew install -v wdiff [...] ln /usr/local/share/locale/af/LC_MESSAGES/wdiff-gnulib.mo ln /usr/local/share/info/wdiff.info ln /usr/local/share/info/dir ==> Summary [...] $ HOMEBREW_KEEP_INFO=1 brew install -v wdiff ln /usr/local/share/locale/af/LC_MESSAGES/wdiff-gnulib.mo ==> Summary [...] Obviously not what we wanted. Closes Homebrew/homebrew#7989. Signed-off-by: Jack Nagel --- Library/Homebrew/cleaner.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/cleaner.rb b/Library/Homebrew/cleaner.rb index 36bb74f4ba..426fbec6a3 100644 --- a/Library/Homebrew/cleaner.rb +++ b/Library/Homebrew/cleaner.rb @@ -3,7 +3,7 @@ class Cleaner @f = Formula.factory f [f.bin, f.sbin, f.lib].select{ |d| d.exist? }.each{ |d| clean_dir d } - unless ENV['HOMEBREW_KEEP_INFO'].nil? + unless ENV['HOMEBREW_KEEP_INFO'] f.info.rmtree if f.info.directory? and not f.skip_clean? f.info end