admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #16622 from reitermarkus/audit-tap-aliases-renames

Browse Source 
Audit taps for duplicates in aliases/renames.
This commit is contained in:
Mike McQuaid 2024-02-09 21:56:38 +00:00 committed by GitHub
commit 73f986908c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Library/Homebrew/tap_auditor.rb
View File

@ -6,7 +6,7 @@ module Homebrew
# #
# @api private # @api private
class TapAuditor class TapAuditor
attr_reader :name, :path, :formula_names, :formula_aliases, :cask_tokens, attr_reader :name, :path, :formula_names, :formula_aliases, :formula_renames, :cask_tokens,
:tap_audit_exceptions, :tap_style_exceptions, :tap_pypi_formula_mappings, :problems :tap_audit_exceptions, :tap_style_exceptions, :tap_pypi_formula_mappings, :problems
sig { params(tap: Tap, strict: T.nilable(T::Boolean)).void } sig { params(tap: Tap, strict: T.nilable(T::Boolean)).void }
@ -23,6 +23,7 @@ module Homebrew
@formula_aliases = tap.aliases.map do |formula_alias| @formula_aliases = tap.aliases.map do |formula_alias|
formula_alias.split("/").last formula_alias.split("/").last
end end
@formula_renames = tap.formula_renames
@formula_names = tap.formula_names.map do |formula_name| @formula_names = tap.formula_names.map do |formula_name|
formula_name.split("/").last formula_name.split("/").last
end end
@ -33,6 +34,7 @@ module Homebrew
def audit def audit
audit_json_files audit_json_files
audit_tap_formula_lists audit_tap_formula_lists
audit_aliases_renames_duplicates
end end
sig { void } sig { void }
@ -52,6 +54,14 @@ module Homebrew
check_formula_list "pypi_formula_mappings", @tap_pypi_formula_mappings check_formula_list "pypi_formula_mappings", @tap_pypi_formula_mappings
end end
sig { void }
def audit_aliases_renames_duplicates
duplicates = formula_aliases & formula_renames.keys
return if duplicates.none?
problem "The following should either be an alias or a rename, not both: #{duplicates.to_sentence}"
end
sig { params(message: String).void } sig { params(message: String).void }
def problem(message) def problem(message)
@problems << ({ message: message, location: nil, corrected: false }) @problems << ({ message: message, location: nil, corrected: false })