admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

bin/brew: quote in assignments for consistency

Browse Source 
While `var=$(<command>)` is perfectly valid and won't create any issues,
it is often surprising for less shell-savvy users. Quoting these cases
like in all other instances makes the code more uniform, helps to avoid
future mistakes, and has no downsides.
This commit is contained in:
Martin Afanasjew 2015-11-20 20:45:38 +01:00
parent fb4a2ea387
commit 73a7889de5
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
bin/brew
View File

@ -3,18 +3,18 @@ chdir() {
cd "$@" >/dev/null
}
BREW_FILE_DIRECTORY=$(chdir "${0%/*}" && pwd -P)
BREW_FILE_DIRECTORY="$(chdir "${0%/*}" && pwd -P)"
export HOMEBREW_BREW_FILE="$BREW_FILE_DIRECTORY/${0##*/}"
BREW_SYMLINK=$(readlink "$0")
BREW_SYMLINK="$(readlink "$0")"
if [ -n "$BREW_SYMLINK" ]
then
BREW_SYMLINK_DIRECTORY=$(dirname "$BREW_SYMLINK")
BREW_FILE_DIRECTORY=$(chdir "$BREW_FILE_DIRECTORY" &&
chdir "$BREW_SYMLINK_DIRECTORY" && pwd -P)
BREW_SYMLINK_DIRECTORY="$(dirname "$BREW_SYMLINK")"
BREW_FILE_DIRECTORY="$(chdir "$BREW_FILE_DIRECTORY" &&
chdir "$BREW_SYMLINK_DIRECTORY" && pwd -P)"
fi
BREW_LIBRARY_DIRECTORY=$(chdir "$BREW_FILE_DIRECTORY"/../Library && pwd -P)
BREW_LIBRARY_DIRECTORY="$(chdir "$BREW_FILE_DIRECTORY"/../Library && pwd -P)"
# Users may have these set, pointing the system Ruby
# at non-system gem paths
@ -28,7 +28,7 @@ fi
if [ -z "$HOMEBREW_RUBY_PATH" ]
then
BREW_SYSTEM=$(uname -s | tr "[:upper:]" "[:lower:]")
BREW_SYSTEM="$(uname -s | tr "[:upper:]" "[:lower:]")"
if [ "$BREW_SYSTEM" = "darwin" ]
then
export HOMEBREW_RUBY_PATH="/System/Library/Frameworks/Ruby.framework/Versions/Current/usr/bin/ruby"