RubyRequirement: clean up

1. Remove dead code (RubyRequirement always has a version)
2. Perfer `Utils.popen_read` instead of backticks.
This commit is contained in:
Xu Cheng 2015-05-08 14:41:19 +08:00
parent dba9675ed3
commit 73277e71b1

View File

@ -10,7 +10,7 @@ class RubyRequirement < Requirement
satisfy :build_env => false do
next unless which "ruby"
version = /\d\.\d/.match `ruby --version 2>&1`
version = /\d\.\d/.match Utils.popen_read("ruby", "--version")
next unless version
Version.new(version.to_s) >= Version.new(@version)
end
@ -20,9 +20,7 @@ class RubyRequirement < Requirement
end
def message
version_string = " #{@version}" if @version
s = "Ruby#{version_string} is required to install this formula."
s = "Ruby #{@version} is required to install this formula."
s += super
s
end