admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_desc_cop: add unnecessary whitespace check

Browse Source
This commit is contained in:
Dominyk Tiller 2018-08-06 18:43:26 +01:00
parent 016ff24c97
commit 73194b460d
No known key found for this signature in database
GPG Key ID: FE19AEFCF658C6F6
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/rubocops/formula_desc_cop.rb
View File

@ -38,6 +38,7 @@ module RuboCop
module FormulaAuditStrict module FormulaAuditStrict
# This cop audits `desc` in Formulae # This cop audits `desc` in Formulae
# #
# - Checks for leading/trailing whitespace in `desc`
# - Checks if `desc` begins with an article # - Checks if `desc` begins with an article
# - Checks for correct usage of `command-line` in `desc` # - Checks for correct usage of `command-line` in `desc`
# - Checks description starts with a capital letter # - Checks description starts with a capital letter
@ -62,6 +63,16 @@ module RuboCop
desc = parameters(desc_call).first desc = parameters(desc_call).first
# Check for leading whitespace.
if regex_match_group(desc, /^\s+/)
problem "Description shouldn't have a leading space"
end
# Check for trailing whitespace.
if regex_match_group(desc, /\s+$/)
problem "Description shouldn't have a trailing space"
end
# Check if command-line is wrongly used in formula's desc # Check if command-line is wrongly used in formula's desc
if match = regex_match_group(desc, /(command ?line)/i) if match = regex_match_group(desc, /(command ?line)/i)
c = match.to_s.chars.first c = match.to_s.chars.first
@ -104,6 +115,8 @@ module RuboCop
correction.gsub!(/^(['"]?)\s+/, "\\1") correction.gsub!(/^(['"]?)\s+/, "\\1")
correction.gsub!(/\s+(['"]?)$/, "\\1") correction.gsub!(/\s+(['"]?)$/, "\\1")
correction.gsub!(/\.(['"]?)$/, "\\1") correction.gsub!(/\.(['"]?)$/, "\\1")
correction.gsub!(/^\s+/, "")
correction.gsub!(/\s+$/, "")
corrector.insert_before(node.source_range, correction) corrector.insert_before(node.source_range, correction)
corrector.remove(node.source_range) corrector.remove(node.source_range)
end end