admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

sudo: Elevate priviliges before adding metadata after relocating a cask, if necessary

Browse Source 
Homebrew cannot assume that target location is writable for chmod and xattr.
This commit is contained in:
Ilya Kulakov 2025-01-20 14:35:36 -08:00
parent 55f399c10d
commit 730a3de1b9
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/cask/artifact/relocated.rb
View File

@ -89,11 +89,14 @@ module Cask
altnames = "(#{altnames})" altnames = "(#{altnames})"
# Some packages are shipped as u=rx (e.g. Bitcoin Core) # Some packages are shipped as u=rx (e.g. Bitcoin Core)
command.run!("/bin/chmod", args: ["--", "u+rw", file, file.realpath]) command.run!("/bin/chmod",
args: ["--", "u+rw", file, file.realpath],
sudo: !file.writable? || !file.realpath.writable?)
command.run!("/usr/bin/xattr", command.run!("/usr/bin/xattr",
args: ["-w", ALT_NAME_ATTRIBUTE, altnames, file], args: ["-w", ALT_NAME_ATTRIBUTE, altnames, file],
print_stderr: false) print_stderr: false,
sudo: !file.writable?)
end end
def printable_target def printable_target