From bf18808930285e250fa2b8b24f37b077f0c00b45 Mon Sep 17 00:00:00 2001 From: "Tim D. Smith" Date: Sat, 3 Sep 2016 22:13:04 -0700 Subject: [PATCH 1/2] Catch system libressl in openssl audit as well The regex didn't match libcrypto.35.dylib, and it should have. --- Library/Homebrew/extend/os/mac/formula_cellar_checks.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb b/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb index 16b4d799f4..25452be069 100644 --- a/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb +++ b/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb @@ -29,7 +29,7 @@ module FormulaCellarChecks keg = Keg.new(formula.prefix) system_openssl = keg.mach_o_files.select do |obj| dlls = obj.dynamically_linked_libraries - dlls.any? { |dll| %r{/usr/lib/lib(crypto|ssl)\.(\d\.)*dylib}.match dll } + dlls.any? { |dll| %r{/usr/lib/lib(crypto|ssl)\..*dylib}.match dll } end return if system_openssl.empty? From a4b4b9cd9056190c17ffbfcf007a30dfdca2b0e6 Mon Sep 17 00:00:00 2001 From: "Tim D. Smith" Date: Sun, 4 Sep 2016 16:28:51 -0700 Subject: [PATCH 2/2] Catch LibreSSL libtls as well Update the description to reflect that we may be talking about either crypto library and neither is okay. :) --- Library/Homebrew/extend/os/mac/formula_cellar_checks.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb b/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb index 25452be069..b3f8250ee1 100644 --- a/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb +++ b/Library/Homebrew/extend/os/mac/formula_cellar_checks.rb @@ -29,13 +29,14 @@ module FormulaCellarChecks keg = Keg.new(formula.prefix) system_openssl = keg.mach_o_files.select do |obj| dlls = obj.dynamically_linked_libraries - dlls.any? { |dll| %r{/usr/lib/lib(crypto|ssl)\..*dylib}.match dll } + dlls.any? { |dll| %r{/usr/lib/lib(crypto|ssl|tls)\..*dylib}.match dll } end return if system_openssl.empty? <<-EOS.undent object files were linked against system openssl - These object files were linked against the deprecated system OpenSSL. + These object files were linked against the deprecated system OpenSSL or + the system's private LibreSSL. Adding `depends_on "openssl"` to the formula may help. #{system_openssl * "\n "} EOS