Merge pull request #7000 from GauthamGoli/argv-cleanup-10

ARGV: Deprecate ARGV.quieter?

Library/Homebrew/cmd/tap.rb

@@ -35,7 +35,7 @@ module Homebrew
              description: "Migrate tapped formulae from symlink-based to directory-based structure."
       switch "--list-pinned",
              description: "List all pinned taps."
-      switch "-q", "--quieter",
+      switch :quiet,
              description: "Suppress any warnings."
       switch :debug
       max_named 2
@@ -57,7 +57,7 @@ module Homebrew
         tap.install clone_target:      ARGV.named.second,
                     force_auto_update: force_auto_update?,
                     full_clone:        full_clone?,
-                    quiet:             args.quieter?
+                    quiet:             Homebrew.args.quiet?
       rescue TapRemoteMismatchError => e
         odie e
       rescue TapAlreadyTappedError

Library/Homebrew/extend/ARGV.rb

@@ -41,10 +41,6 @@ module HomebrewArgvExtension
     flag?("--debug") || !ENV["HOMEBREW_DEBUG"].nil?
   end
 
-  def quieter?
-    flag? "--quieter"
-  end
-
   def interactive?
     flag? "--interactive"
   end

Library/Homebrew/formula_installer.rb

@@ -42,7 +42,7 @@ class FormulaInstaller
   mode_attr_accessor :show_summary_heading, :show_header
   mode_attr_accessor :build_from_source, :force_bottle, :include_test
   mode_attr_accessor :ignore_deps, :only_deps, :interactive, :git
-  mode_attr_accessor :verbose, :debug, :quieter
+  mode_attr_accessor :verbose, :debug, :quiet
 
   def initialize(formula)
     @formula = formula
@@ -57,7 +57,7 @@ class FormulaInstaller
     @interactive = false
     @git = false
     @verbose = Homebrew.args.verbose?
-    @quieter = ARGV.quieter?
+    @quiet = Homebrew.args.quiet?
     @debug = ARGV.debug?
     @installed_as_dependency = false
     @installed_on_request = true
@@ -589,7 +589,7 @@ class FormulaInstaller
     fi.build_from_source       = ARGV.build_formula_from_source?(df)
     fi.force_bottle            = false
     fi.verbose                 = verbose?
-    fi.quieter                 = quieter?
+    fi.quiet                   = quiet?
     fi.debug                   = debug?
     fi.link_keg              ||= keg_was_linked if keg_had_linked_keg
     fi.installed_as_dependency = true

docs/Manpage.md

@@ -504,8 +504,6 @@ HTTPS, e.g. SSH, GIT, HTTP, FTP(S), RSYNC.
   Migrate tapped formulae from symlink-based to directory-based structure.
 * `--list-pinned`:
   List all pinned taps.
-* `-q`, `--quieter`:
-  Suppress any warnings.
 
 ### `tap-info` [*`options`*] [*`tap`*]
 

manpages/brew.1

@@ -641,10 +641,6 @@ Migrate tapped formulae from symlink\-based to directory\-based structure\.
 \fB\-\-list\-pinned\fR
 List all pinned taps\.
 .
-.TP
-\fB\-q\fR, \fB\-\-quieter\fR
-Suppress any warnings\.
-.
 .SS "\fBtap\-info\fR [\fIoptions\fR] [\fItap\fR]"
 Show detailed information about one or more \fItap\fRs\.
 .