linkage_checker: system framework links are harmless.

These do not seem to cause runtime errors. Fixes #9338
2020-11-30 14:23:59 +00:00 · 2020-11-30 14:23:59 +00:00 · 7228e60da5
commit 7228e60da5
parent f5bd2ee0c3
1 changed files with 3 additions and 1 deletions
--- a/Library/Homebrew/linkage_checker.rb
+++ b/Library/Homebrew/linkage_checker.rb
@ -285,10 +285,12 @@ class LinkageChecker
  def harmless_broken_link?(dylib)
    # libgcc_s_* is referenced by programs that use the Java Service Wrapper,
    # and is harmless on x86(_64) machines
-    [
+    return true if [
      "/usr/lib/libgcc_s_ppc64.1.dylib",
      "/opt/local/lib/libgcc/libgcc_s.1.dylib",
    ].include?(dylib)
+
+    dylib.start_with?("/System/Library/Frameworks/")
  end

  # Display a list of things.