admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #15269 from MikeMcQuaid/audit_no_warnings

Browse Source 
dev-cmd/audit: remove unused warnings key.
This commit is contained in:
Mike McQuaid 2023-04-19 16:22:13 +01:00 committed by GitHub
commit 71de574285
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Library/Homebrew/dev-cmd/audit.rb
View File

@ -239,7 +239,7 @@ module Homebrew
end end
end end
[f.path, { errors: fa.problems + fa.new_formula_problems, warnings: [] }] [f.path, fa.problems + fa.new_formula_problems]
end end
cask_results = if audit_casks.empty? cask_results = if audit_casks.empty?
@ -272,11 +272,11 @@ module Homebrew
only: args.only, only: args.only,
except: args.except, except: args.except,
) )
[cask.sourcefile_path, { errors: errors, warnings: [] }] [cask.sourcefile_path, errors]
end end
end end
failed_casks = cask_results.reject { |_, result| result[:errors].empty? } failed_casks = cask_results.select { |_, problems| problems.present? }
cask_count = failed_casks.count cask_count = failed_casks.count
@ -309,20 +309,17 @@ module Homebrew
return unless ENV["GITHUB_ACTIONS"] return unless ENV["GITHUB_ACTIONS"]
annotations = formula_results.merge(cask_results).flat_map do |path, result| annotations = formula_results.merge(cask_results).flat_map do |path, problem|
( next if problem.blank?
result[:warnings].map { |w| [:warning, w] } +
result[:errors].map { |e| [:error, e] }
).map do |type, problem|
GitHub::Actions::Annotation.new( GitHub::Actions::Annotation.new(
type, :error,
problem[:message], problem[:message],
file: path, file: path,
line: problem[:location]&.line, line: problem[:location]&.line,
column: problem[:location]&.column, column: problem[:location]&.column,
) )
end end.compact
end
annotations.each do |annotation| annotations.each do |annotation|
puts annotation if annotation.relevant? puts annotation if annotation.relevant?