admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/bump*: improve autobump messaging.

Browse Source 
Let's make it clearer _why_ autobumped PRs cannot be submitted by humans
and, while we're here, similarly for disabled/head-only packages.
This commit is contained in:
Mike McQuaid 2024-05-31 10:23:13 +01:00
parent 968d56cb7a
commit 712ca361d7
No known key found for this signature in database
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/dev-cmd/bump-cask-pr.rb
View File

@ -83,7 +83,7 @@ module Homebrew
odie <<~EOS unless cask.tap.allow_bump?(cask.token) odie <<~EOS unless cask.tap.allow_bump?(cask.token)
Whoops, the #{cask.token} cask has its version update Whoops, the #{cask.token} cask has its version update
pull requests automatically opened by BrewTestBot! pull requests automatically opened by BrewTestBot every ~3 hours!
We'd still love your contributions, though, so try another one We'd still love your contributions, though, so try another one
that's not in the autobump list: that's not in the autobump list:
#{Formatter.url("#{cask.tap.remote}/blob/master/.github/autobump.txt")} #{Formatter.url("#{cask.tap.remote}/blob/master/.github/autobump.txt")}

2
Library/Homebrew/dev-cmd/bump-formula-pr.rb
View File

@ -113,7 +113,7 @@ module Homebrew
odie <<~EOS unless formula.tap.allow_bump?(formula.name) odie <<~EOS unless formula.tap.allow_bump?(formula.name)
Whoops, the #{formula.name} formula has its version update Whoops, the #{formula.name} formula has its version update
pull requests automatically opened by BrewTestBot! pull requests automatically opened by BrewTestBot every ~3 hours!
We'd still love your contributions, though, so try another one We'd still love your contributions, though, so try another one
that's not in the autobump list: that's not in the autobump list:
#{Formatter.url("#{formula.tap.remote}/blob/master/.github/autobump.txt")} #{Formatter.url("#{formula.tap.remote}/blob/master/.github/autobump.txt")}

6
Library/Homebrew/dev-cmd/bump.rb
View File

@ -223,15 +223,15 @@ module Homebrew
if formula_or_cask.is_a?(Formula) if formula_or_cask.is_a?(Formula)
skip = formula_or_cask.disabled? || formula_or_cask.head_only? skip = formula_or_cask.disabled? || formula_or_cask.head_only?
name = formula_or_cask.name name = formula_or_cask.name
text = "Formula is #{formula_or_cask.disabled? ? "disabled" : "HEAD-only"}.\n" text = "Formula is #{formula_or_cask.disabled? ? "disabled" : "HEAD-only"} so not accepting updates.\n"
else else
skip = formula_or_cask.disabled? skip = formula_or_cask.disabled?
name = formula_or_cask.token name = formula_or_cask.token
text = "Cask is disabled.\n" text = "Cask is disabled so not accepting updates.\n"
end end
if (tap = formula_or_cask.tap) && !tap.allow_bump?(name) if (tap = formula_or_cask.tap) && !tap.allow_bump?(name)
skip = true skip = true
text = "#{text.split.first} is on autobump list.\n" text = "#{text.split.first} is autobumped so will have bump PRs opened by BrewTestBot every ~3 hours.\n"
end end
return false unless skip return false unless skip