From 706b06942f2ccedc1adfdea98d9306c22525eca3 Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Tue, 12 Jul 2016 02:54:15 +0100 Subject: [PATCH] audit: update ruby dependency advice Closes #495. Signed-off-by: Dominyk Tiller --- Library/Homebrew/cmd/audit.rb | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index be4febc705..90c08fc4a0 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -363,10 +363,16 @@ class FormulaAuditor problem "Don't use git as a dependency" when "mercurial" problem "Use `depends_on :hg` instead of `depends_on 'mercurial'`" - when "ruby" - problem "Don't use ruby as a dependency. We allow non-Homebrew ruby installations." when "gfortran" problem "Use `depends_on :fortran` instead of `depends_on 'gfortran'`" + when "ruby" + problem <<-EOS.undent + Don't use "ruby" as a dependency. If this formula requires a + minimum Ruby version not provided by the system you should + use the RubyRequirement: + depends_on :ruby => "1.8" + where "1.8" is the minimum version of Ruby required. + EOS when "open-mpi", "mpich" problem <<-EOS.undent There are multiple conflicting ways to install MPI. Use an MPIRequirement: