From f4f18acf88d5c797e93e061ca3b0a12e546e3762 Mon Sep 17 00:00:00 2001 From: Max schwenk Date: Tue, 5 Sep 2023 16:30:30 -0400 Subject: [PATCH 1/2] Fix bad cache setting --- Library/Homebrew/requirement.rb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/requirement.rb b/Library/Homebrew/requirement.rb index 72e77249cc..592b07e791 100644 --- a/Library/Homebrew/requirement.rb +++ b/Library/Homebrew/requirement.rb @@ -239,7 +239,10 @@ class Requirement end end - cache[cache_key][cache_id dependent] = reqs.dup if cache_key.present? + if cache_key.present? + cache[cache_key] ||= {} + cache[cache_key][cache_id dependent] = reqs.dup + end reqs end From db19e99095c67b7cad043b9b465c56785c26a8a4 Mon Sep 17 00:00:00 2001 From: Max schwenk Date: Tue, 5 Sep 2023 22:40:23 -0400 Subject: [PATCH 2/2] Add a comment to that effect --- Library/Homebrew/requirement.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Library/Homebrew/requirement.rb b/Library/Homebrew/requirement.rb index 592b07e791..4d5fa7e0d2 100644 --- a/Library/Homebrew/requirement.rb +++ b/Library/Homebrew/requirement.rb @@ -240,6 +240,9 @@ class Requirement end if cache_key.present? + # Even though we setup the cache above + # 'dependent.recursive_dependencies.map(&:to_formula)' + # is invalidating the singleton cache cache[cache_key] ||= {} cache[cache_key][cache_id dependent] = reqs.dup end