admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: only perform GNU URL check on primary URLs

Browse Source 
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Jack Nagel 2011-11-30 13:14:24 -06:00
parent 1657bb1fcf
commit 6f83e20f49
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Library/Homebrew/cmd/audit.rb
View File

@ -198,6 +198,14 @@ def audit_formula_urls f
urls = [(f.url rescue nil), (f.head rescue nil)].reject {|p| p.nil?} urls = [(f.url rescue nil), (f.head rescue nil)].reject {|p| p.nil?}
urls.uniq! # head-only formulae result in duplicate entries urls.uniq! # head-only formulae result in duplicate entries
# Check GNU urls; doesn't apply to mirrors
urls.each do |p|
if p =~ %r[^(https?|ftp)://(.+)/gnu/]
problems << " * \"ftpmirror.gnu.org\" is preferred for GNU software."
end
end
# the rest of the checks apply to mirrors as well
f.mirrors.each do |m| f.mirrors.each do |m|
mirror = m.values_at :url mirror = m.values_at :url
urls << (mirror.to_s rescue nil) urls << (mirror.to_s rescue nil)
@ -236,14 +244,6 @@ def audit_formula_urls f
end end
end end
# Check GNU urls
# FIXME only check primary URLs, not mirrors
# urls.each do |p|
# if p =~ %r[^(https?|ftp)://(.+)/gnu/]
# problems << " * \"ftpmirror.gnu.org\" is preferred for GNU software."
# end
# end
return problems return problems
end end