add tests

This commit is contained in:
Bevan Kay 2022-01-11 13:18:06 +11:00
parent 7e24930e4e
commit 6f62b0e029
No known key found for this signature in database
GPG Key ID: C55CB024B5314B57

View File

@ -0,0 +1,103 @@
# typed: false
# frozen_string_literal: true
require "rubocops/rubocop-cask"
require "test/rubocops/cask/shared_examples/cask_cop"
describe RuboCop::Cop::Cask::UrlLegacyCommaSeparators do
include CaskCop
subject(:cop) { described_class.new }
context "when url version interpolation does not include version.before_comma or version.after_comma" do
let(:source) do
<<-CASK.undent
cask 'foo' do
version '1.1'
url 'https://foo.brew.sh/foo-#{version}.dmg'
end
CASK
end
include_examples "does not report any offenses"
end
context "when the url uses csv" do
let(:source) do
<<-CASK.undent
cask 'foo' do
version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.csv.first}.dmg'
end
CASK
end
include_examples "does not report any offenses"
end
context "when the url uses version.before_comma" do
let(:source) do
<<-CASK.undent
cask 'foo' do
version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.before_comma}.dmg'
end
CASK
end
let(:correct_source) do
<<-CASK.undent
cask 'foo' do
version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.csv.first}.dmg'
end
CASK
end
let(:expected_offenses) do
[{
message: "'https://foo.brew.sh/foo-#{version.before_comma}.dmg' should use "\
"#{version.csv.first} instead of #{version.before_comma}.'",
severity: :convention,
line: 2,
column: 11,
source: "'https://foo.brew.sh/foo-#{version.before_comma}.dmg'",
}]
end
include_examples "reports offenses"
include_examples "autocorrects source"
end
context "when the url uses version.after_comma" do
let(:source) do
<<-CASK.undent
cask 'foo' do
version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.after_comma}.dmg'
end
CASK
end
let(:correct_source) do
<<-CASK.undent
cask 'foo' do
version '1.1,111'
url 'https://foo.brew.sh/foo-#{version.csv.second}.dmg'
end
CASK
end
let(:expected_offenses) do
[{
message: "'https://foo.brew.sh/foo-#{version.after_comma}.dmg' should use "\
"#{version.csv.second} instead of #{version.after_comma}.'",
severity: :convention,
line: 2,
column: 11,
source: "'https://foo.brew.sh/foo-#{version.after_comma}.dmg'",
}]
end
include_examples "reports offenses"
include_examples "autocorrects source"
end
end