From 6f2f97b98f1069fa299386fca31502e1101dbf13 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Thu, 3 Nov 2022 23:11:41 +0000 Subject: [PATCH] test/rubocops/formula_desc: Ensure autocorrect when `desc` ends in `.` - This was another thing that I should have done in PR 3411 in 2017, tested that the regex for autocorrecting `desc` stanzas ending in full stops actually worked. At least I'm getting to it now. --- Library/Homebrew/test/rubocops/formula_desc_spec.rb | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/test/rubocops/formula_desc_spec.rb b/Library/Homebrew/test/rubocops/formula_desc_spec.rb index 0a8c81ce21..27280ab5da 100644 --- a/Library/Homebrew/test/rubocops/formula_desc_spec.rb +++ b/Library/Homebrew/test/rubocops/formula_desc_spec.rb @@ -118,12 +118,19 @@ describe RuboCop::Cop::FormulaAudit::Desc do RUBY end - it "reports an offense when the description ends with a full stop" do + it "report and corrects an offense when the description ends with a full stop" do expect_offense(<<~RUBY, "/homebrew-core/Formula/foo.rb") class Foo < Formula url 'https://brew.sh/foo-1.0.tgz' desc 'Description with a full stop at the end.' - ^ Description shouldn\'t end with a full stop. + ^ Description shouldn't end with a full stop. + end + RUBY + + expect_correction(<<~RUBY) + class Foo < Formula + url 'https://brew.sh/foo-1.0.tgz' + desc 'Description with a full stop at the end' end RUBY end