admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add test for legacy prefix quoting.

Browse Source
This commit is contained in:
Adam Vandenberg 2009-11-18 15:43:00 -08:00
parent 47a38f49f1
commit 6e7731aeff
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/test/formula_test.rb
View File

@ -39,11 +39,22 @@ class FormulaNames <Test::Unit::TestCase
end end
end end
class CommentedTemplateCode <Test::Unit::TestCase class WellKnownCodeIssues <Test::Unit::TestCase
def test_for_commented_out_cmake def test_for_commented_out_cmake
Dir["#{HOMEBREW_PREFIX}/Library/Formula/*.rb"].each do |f| Dir["#{HOMEBREW_PREFIX}/Library/Formula/*.rb"].each do |f|
result = `grep "# depends_on 'cmake'" "#{f}"`.strip result = `grep "# depends_on 'cmake'" "#{f}"`.strip
assert_equal('', result, "Commented template code still in #{f}") assert_equal('', result, "Commented template code still in #{f}")
end end
end end
end
def test_for_misquoted_prefix
# Prefix should not have single quotes if the system args are already separated
target_string = "[\\\"]--prefix=[\\']"
Dir["#{HOMEBREW_PREFIX}/Library/Formula/*.rb"].each do |f|
result = `grep -e "#{target_string}" "#{f}"`.strip
assert_equal('', result, "--prefix is incorrectly single-quoted in #{f}")
end
end
end