admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #18946 from vidishanevatia/fix-cask-list-symlinks

Browse Source 
Fixes  #18849 :  fix duplicate casks when symlinks exist
This commit is contained in:
Mike McQuaid 2024-12-17 11:58:53 +00:00 committed by GitHub
commit 6d2a50094f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Library/Homebrew/cmd/list.rb
View File

@ -214,7 +214,15 @@ module Homebrew
sig { void } sig { void }
def list_casks def list_casks
casks = if args.no_named? casks = if args.no_named?
Cask::Caskroom.casks cask_paths = Cask::Caskroom.path.children.map do |path|
if path.symlink?
real_path = path.realpath
real_path.basename.to_s
else
path.basename.to_s
end
end.uniq
cask_paths.map { |name| Cask::CaskLoader.load(name) }
else else
filtered_args = args.named.dup.delete_if do |n| filtered_args = args.named.dup.delete_if do |n|
Homebrew.failed = true unless Cask::Caskroom.path.join(n).exist? Homebrew.failed = true unless Cask::Caskroom.path.join(n).exist?