From 5fe38ad7a0d8ff49701d418c45e71f08b158de1b Mon Sep 17 00:00:00 2001 From: vidusheeamoli Date: Fri, 3 Jul 2020 00:44:54 +0530 Subject: [PATCH] srb: set utils files to true Set utils/bottles.rb, utils/shell.rb and utils/svn.rb to true so that type errors in these files may be reported by Sorbet (cherry picked from commit fd3db131b0da78169fdff2031180a2bebe3cbb84) --- Library/Homebrew/sorbet/files.yaml | 6 ++-- Library/Homebrew/sorbet/rbi/utils/shell.rbi | 38 +++++++++++++++++++++ Library/Homebrew/sorbet/rbi/utils/utils.rbi | 8 +++++ 3 files changed, 49 insertions(+), 3 deletions(-) create mode 100644 Library/Homebrew/sorbet/rbi/utils/shell.rbi create mode 100644 Library/Homebrew/sorbet/rbi/utils/utils.rbi diff --git a/Library/Homebrew/sorbet/files.yaml b/Library/Homebrew/sorbet/files.yaml index 50900c4005..73b633f293 100644 --- a/Library/Homebrew/sorbet/files.yaml +++ b/Library/Homebrew/sorbet/files.yaml @@ -445,7 +445,6 @@ false: - ./unpack_strategy/zip.rb - ./utils.rb - ./utils/analytics.rb - - ./utils/bottles.rb - ./utils/curl.rb - ./utils/fork.rb - ./utils/formatter.rb @@ -847,8 +846,6 @@ false: - ./utils/inreplace.rb - ./utils/link.rb - ./utils/shebang.rb - - ./utils/shell.rb - - ./utils/svn.rb - ./version.rb true: @@ -888,6 +885,9 @@ true: - ./tap_constants.rb - ./test/support/helper/fixtures.rb - ./test/support/lib/config.rb + - ./utils/bottles.rb + - ./utils/shell.rb + - ./utils/svn.rb - ./utils/tty.rb - ./version/null.rb diff --git a/Library/Homebrew/sorbet/rbi/utils/shell.rbi b/Library/Homebrew/sorbet/rbi/utils/shell.rbi new file mode 100644 index 0000000000..f4a3507bd8 --- /dev/null +++ b/Library/Homebrew/sorbet/rbi/utils/shell.rbi @@ -0,0 +1,38 @@ +# typed: strict + +module Utils::Shell + include Kernel + + sig{ params(path: String).returns(T.nilable(Symbol)) } + def from_path(path) + end + + sig{ returns(T.nilable(Symbol)) } + def preferred + end + + def parent + end + + def export_value(key, value, shell = preferred) + end + + sig{ returns(String) } + def profile + end + + def set_variable_in_profile(variable, value) + end + + sig{ params(path: String).returns(T.nilable(String)) } + def prepend_path_in_profile(path) + end + + sig{ params(str: String).returns(T.nilable(String)) } + def csh_quote(str) + end + + sig{ params(str: String).returns(T.nilable(String)) } + def sh_quote(str) + end +end diff --git a/Library/Homebrew/sorbet/rbi/utils/utils.rbi b/Library/Homebrew/sorbet/rbi/utils/utils.rbi new file mode 100644 index 0000000000..f015d7204d --- /dev/null +++ b/Library/Homebrew/sorbet/rbi/utils/utils.rbi @@ -0,0 +1,8 @@ +# typed: strict + +module Utils + include Kernel + + class Bottles + end +end