rubocop/lines: add whitelist.
Let's only allow cryto or libraries.
This commit is contained in:
parent
e47a6ac4cb
commit
6bc72cf18a
@ -424,6 +424,25 @@ module RuboCop
|
|||||||
|
|
||||||
# Avoid build-time checks in homebrew/core
|
# Avoid build-time checks in homebrew/core
|
||||||
find_every_method_call_by_name(body_node, :system).each do |method|
|
find_every_method_call_by_name(body_node, :system).each do |method|
|
||||||
|
next if @formula_name.start_with?("lib")
|
||||||
|
next if %w[
|
||||||
|
beecrypt
|
||||||
|
ccrypt
|
||||||
|
git
|
||||||
|
gmp
|
||||||
|
gnupg
|
||||||
|
gnupg@1.4
|
||||||
|
google-sparsehash
|
||||||
|
jemalloc
|
||||||
|
jpeg-turbo
|
||||||
|
mpfr
|
||||||
|
open-mpi
|
||||||
|
openssl@1.1
|
||||||
|
pcre
|
||||||
|
wolfssl
|
||||||
|
xz
|
||||||
|
].include?(@formula_name)
|
||||||
|
|
||||||
params = parameters(method)
|
params = parameters(method)
|
||||||
next unless node_equals?(params[0], "make")
|
next unless node_equals?(params[0], "make")
|
||||||
|
|
||||||
@ -431,7 +450,8 @@ module RuboCop
|
|||||||
next unless regex_match_group(arg, /^(checks?|tests?)$/)
|
next unless regex_match_group(arg, /^(checks?|tests?)$/)
|
||||||
|
|
||||||
offending_node(method)
|
offending_node(method)
|
||||||
problem "Formulae in homebrew/core should not run build-time checks"
|
problem "Formulae in homebrew/core (except e.g. cryptography, libraries) " \
|
||||||
|
"should not run build-time checks"
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@ -355,7 +355,7 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
|
|||||||
desc "foo"
|
desc "foo"
|
||||||
url 'https://brew.sh/foo-1.0.tgz'
|
url 'https://brew.sh/foo-1.0.tgz'
|
||||||
system "make", "-j1", "test"
|
system "make", "-j1", "test"
|
||||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Formulae in homebrew/core should not run build-time checks
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Formulae in homebrew/core (except e.g. cryptography, libraries) should not run build-time checks
|
||||||
end
|
end
|
||||||
RUBY
|
RUBY
|
||||||
end
|
end
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user