admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

dev-cmd/contributions: Stop counting signoffs now we have "real" reviews

Browse Source 
- Signoffs were just a stopgap until we implemented getting "real"
  reviews for a user via the GitHub API. They were a suboptimal way of getting
  reviews because they only really exist in Homebrew/homebrew-core where
  BrewTestBot adds signoffs for each maintainer who reviewed the PR.
This commit is contained in:
Issy Long 2023-02-26 13:00:56 +00:00
parent 6db7732fa3
commit 6b76e5e66f
No known key found for this signature in database
GPG Key ID: 8247C390DADC67D4
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Library/Homebrew/dev-cmd/contributions.rb
View File

@ -108,7 +108,7 @@ module Homebrew
sig { params(totals: Hash).returns(String) } sig { params(totals: Hash).returns(String) }
def generate_maintainers_csv(totals) def generate_maintainers_csv(totals)
CSV.generate do |csv| CSV.generate do |csv|
csv << %w[user repo commits coauthorships signoffs reviews total] csv << %w[user repo commits coauthorships reviews total]
totals.sort_by { |_, v| -v.values.sum }.each do |user, total| totals.sort_by { |_, v| -v.values.sum }.each do |user, total|
csv << grand_total_row(user, total) csv << grand_total_row(user, total)
@ -119,14 +119,13 @@ module Homebrew
sig { params(user: String, results: Hash, grand_total: Hash).returns(String) } sig { params(user: String, results: Hash, grand_total: Hash).returns(String) }
def generate_csv(user, results, grand_total) def generate_csv(user, results, grand_total)
CSV.generate do |csv| CSV.generate do |csv|
csv << %w[user repo commits coauthorships signoffs reviews total] csv << %w[user repo commits coauthorships reviews total]
results.each do |repo, counts| results.each do |repo, counts|
csv << [ csv << [
user, user,
repo, repo,
counts[:commits], counts[:commits],
counts[:coauthorships], counts[:coauthorships],
counts[:signoffs],
counts[:reviews], counts[:reviews],
counts.values.sum, counts.values.sum,
] ]
@ -142,7 +141,6 @@ module Homebrew
"all", "all",
grand_total[:commits], grand_total[:commits],
grand_total[:coauthorships], grand_total[:coauthorships],
grand_total[:signoffs],
grand_total[:reviews], grand_total[:reviews],
grand_total.values.sum, grand_total.values.sum,
] ]
@ -174,7 +172,6 @@ module Homebrew
data[repo] = { data[repo] = {
commits: GitHub.repo_commit_count_for_user(repo_full_name, person, args), commits: GitHub.repo_commit_count_for_user(repo_full_name, person, args),
coauthorships: git_log_trailers_cmd(T.must(repo_path), person, "Co-authored-by", args), coauthorships: git_log_trailers_cmd(T.must(repo_path), person, "Co-authored-by", args),
signoffs: git_log_trailers_cmd(T.must(repo_path), person, "Signed-off-by", args),
reviews: GitHub.count_issues("", is: "pr", repo: repo_full_name, reviewed_by: person, args: args), reviews: GitHub.count_issues("", is: "pr", repo: repo_full_name, reviewed_by: person, args: args),
} }
end end
@ -184,11 +181,11 @@ module Homebrew
sig { params(results: Hash).returns(Hash) } sig { params(results: Hash).returns(Hash) }
def total(results) def total(results)
totals = { commits: 0, coauthorships: 0, signoffs: 0, reviews: 0 } totals = { commits: 0, coauthorships: 0, reviews: 0 }
# { # {
# "brew"=>{:commits=>9,:coauthorships=>6,:signoffs=>3,:reviews=>1}, # "brew"=>{:commits=>9,:coauthorships=>6,:reviews=>1},
# "core"=>{:commits=>15,:coauthorships=>10,:signoffs=>5,:reviews=>2} # "core"=>{:commits=>15,:coauthorships=>10,:reviews=>2}
# } # }
results.each_value do |counts| results.each_value do |counts|
counts.each do |kind, count| counts.each do |kind, count|
@ -196,7 +193,7 @@ module Homebrew
end end
end end
totals # {:commits=>24,:coauthorships=>16,:signoffs=>8,:reviews=>3} totals # {:commits=>24,:coauthorships=>16,:reviews=>3}
end end
sig { params(repo_path: Pathname, person: String, trailer: String, args: Homebrew::CLI::Args).returns(Integer) } sig { params(repo_path: Pathname, person: String, trailer: String, args: Homebrew::CLI::Args).returns(Integer) }