diff --git a/Library/Homebrew/dev-cmd/bump-cask-pr.rb b/Library/Homebrew/dev-cmd/bump-cask-pr.rb index d6b1586e0b..cc33184b1a 100644 --- a/Library/Homebrew/dev-cmd/bump-cask-pr.rb +++ b/Library/Homebrew/dev-cmd/bump-cask-pr.rb @@ -156,11 +156,11 @@ module Homebrew end if new_hash.present? && cask.language.blank? # avoid repeated replacement for multilanguage cask - hash_regex = old_hash == :no_check ? ":no_check" : "[\"']#{Regexp.escape(old_hash.to_s)}[\"']" + hash_regex = (old_hash == :no_check) ? ":no_check" : "[\"']#{Regexp.escape(old_hash.to_s)}[\"']" replacement_pairs << [ /sha256\s+#{hash_regex}/m, - "sha256 #{new_hash == :no_check ? ":no_check" : "\"#{new_hash}\""}", + "sha256 #{(new_hash == :no_check) ? ":no_check" : "\"#{new_hash}\""}", ] end diff --git a/Library/Homebrew/rubocops/lines.rb b/Library/Homebrew/rubocops/lines.rb index e8c7a631a3..d8fd97bead 100644 --- a/Library/Homebrew/rubocops/lines.rb +++ b/Library/Homebrew/rubocops/lines.rb @@ -401,7 +401,7 @@ module RuboCop info[:if_module], info[:if_method] = if ON_ARCH_OPTIONS.include?(on_system_option) ["Hardware::CPU", :"#{on_system_option}?"] elsif ON_BASE_OS_OPTIONS.include?(on_system_option) - ["OS", on_system_option == :macos ? :mac? : :linux?] + ["OS", (on_system_option == :macos) ? :mac? : :linux?] else ["MacOS", :version] end @@ -493,7 +493,7 @@ module RuboCop else_info = if else_node.present? { can_autocorrect: true, - on_system_method: on_system_option == :intel ? "on_arm" : "on_intel", + on_system_method: (on_system_option == :intel) ? "on_arm" : "on_intel", node: else_node, } end @@ -505,7 +505,7 @@ module RuboCop else_info = if else_node.present? { can_autocorrect: true, - on_system_method: on_system_option == :macos ? "on_linux" : "on_macos", + on_system_method: (on_system_option == :macos) ? "on_linux" : "on_macos", node: else_node, } end diff --git a/Library/Homebrew/service.rb b/Library/Homebrew/service.rb index f40cff066f..3ef98c0792 100644 --- a/Library/Homebrew/service.rb +++ b/Library/Homebrew/service.rb @@ -405,7 +405,7 @@ module Homebrew cmd = command.join(" ") options = [] - options << "Type=#{@launch_only_once == true ? "oneshot" : "simple"}" + options << "Type=#{(@launch_only_once == true) ? "oneshot" : "simple"}" options << "ExecStart=#{cmd}" options << "Restart=always" if @keep_alive.present? && @keep_alive[:always].present? @@ -441,8 +441,8 @@ module Homebrew options << "OnUnitActiveSec=#{@interval}" if @run_type == RUN_TYPE_INTERVAL if @run_type == RUN_TYPE_CRON - minutes = @cron[:Minute] == "*" ? "*" : format("%02d", @cron[:Minute]) - hours = @cron[:Hour] == "*" ? "*" : format("%02d", @cron[:Hour]) + minutes = (@cron[:Minute] == "*") ? "*" : format("%02d", @cron[:Minute]) + hours = (@cron[:Hour] == "*") ? "*" : format("%02d", @cron[:Hour]) options << "OnCalendar=#{@cron[:Weekday]}-*-#{@cron[:Month]}-#{@cron[:Day]} #{hours}:#{minutes}:00" end diff --git a/Library/Homebrew/software_spec.rb b/Library/Homebrew/software_spec.rb index 0a246d3469..6b4c15981e 100644 --- a/Library/Homebrew/software_spec.rb +++ b/Library/Homebrew/software_spec.rb @@ -582,7 +582,7 @@ class BottleSpecification tags = collector.tags.sort_by do |tag| version = tag.to_macos_version # Give arm64 bottles a higher priority so they are first - priority = tag.arch == :arm64 ? "2" : "1" + priority = (tag.arch == :arm64) ? "2" : "1" "#{priority}.#{version}_#{tag}" rescue MacOSVersionError # Sort non-MacOS tags below MacOS tags. diff --git a/Library/Homebrew/style.rb b/Library/Homebrew/style.rb index 8b253c0f5f..ce38f1a1af 100644 --- a/Library/Homebrew/style.rb +++ b/Library/Homebrew/style.rb @@ -49,7 +49,7 @@ module Homebrew .partition { |f| f.realpath == HOMEBREW_BREW_FILE.realpath || f.extname == ".sh" } rubocop_result = if shell_files.any? && ruby_files.none? - output_type == :json ? [] : true + (output_type == :json) ? [] : true else run_rubocop(ruby_files, output_type, fix: fix, @@ -60,7 +60,7 @@ module Homebrew end shellcheck_result = if ruby_files.any? && shell_files.none? - output_type == :json ? [] : true + (output_type == :json) ? [] : true else run_shellcheck(shell_files, output_type, fix: fix) end diff --git a/Library/Homebrew/tap.rb b/Library/Homebrew/tap.rb index 7a2fba9256..c41753c6e7 100644 --- a/Library/Homebrew/tap.rb +++ b/Library/Homebrew/tap.rb @@ -252,7 +252,7 @@ class Tap if official? && DEPRECATED_OFFICIAL_TAPS.include?(repo) odie "#{name} was deprecated. This tap is now empty and all its contents were either deleted or migrated." elsif user == "caskroom" || name == "phinze/cask" - new_repo = repo == "cask" ? "cask" : "cask-#{repo}" + new_repo = (repo == "cask") ? "cask" : "cask-#{repo}" odie "#{name} was moved. Tap homebrew/#{new_repo} instead." end diff --git a/Library/Homebrew/test/support/fixtures/cask/Casks/with-depends-on-macos-failure.rb b/Library/Homebrew/test/support/fixtures/cask/Casks/with-depends-on-macos-failure.rb index 652ac08b8e..9dbddb789e 100644 --- a/Library/Homebrew/test/support/fixtures/cask/Casks/with-depends-on-macos-failure.rb +++ b/Library/Homebrew/test/support/fixtures/cask/Casks/with-depends-on-macos-failure.rb @@ -6,7 +6,7 @@ cask "with-depends-on-macos-failure" do homepage "https://brew.sh/with-depends-on-macos-failure" # guarantee a mismatched release - depends_on macos: MacOS.version == :catalina ? :mojave : :catalina + depends_on macos: (MacOS.version == :catalina) ? :mojave : :catalina app "Caffeine.app" end