From 6b5b8757bff12a3ad7089534a33935229964cff1 Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Mon, 18 Jan 2016 11:31:51 +0800 Subject: [PATCH] bin/brew: fix incorrect argument manipulation Shifting `-v` argument is all we need to do. We shouldn't enumerate arguments. --- bin/brew | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/bin/brew b/bin/brew index 7eeb35db70..046e8ee29b 100755 --- a/bin/brew +++ b/bin/brew @@ -118,18 +118,15 @@ then exit 1 fi -for i in "$@" -do - if [[ "$1" = -v ]] - then - shift - set -- "$@" -v - fi - [[ "$i" =~ ^- ]] && continue - HOMEBREW_COMMAND="$i" - HOMEBREW_BASH_COMMAND="$HOMEBREW_LIBRARY/Homebrew/cmd/$i.sh" - break -done +if [[ "$1" = -v ]] +then + # Shift the -v to the end of the parameter list + shift + set -- "$@" -v +fi + +HOMEBREW_COMMAND="$1" +HOMEBREW_BASH_COMMAND="$HOMEBREW_LIBRARY/Homebrew/cmd/$1.sh" if [ "$(id -u)" = "0" ] && [ "$(stat -f%u "$HOMEBREW_BREW_FILE")" != "0" ] then