admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: fix false negative for formulae options.

Browse Source 
Handle the case where an if/unless is detected and then write off this
line for option handling.
This commit is contained in:
Mike McQuaid 2017-06-02 22:26:37 +01:00
parent 0731a68cde
commit 6a0086a0a7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Library/Homebrew/dev-cmd/audit.rb
View File

@ -959,6 +959,7 @@ class FormulaAuditor
if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+(.*)/ if line =~ /depends_on\s+['"](.+)['"]\s+=>\s+(.*)/
dep = $1 dep = $1
$2.split(" ").map do |o| $2.split(" ").map do |o|
break if ["if", "unless"].include?(o)
next unless o =~ /^\[?['"](.*)['"]/ next unless o =~ /^\[?['"](.*)['"]/
problem "Dependency #{dep} should not use option #{$1}" problem "Dependency #{dep} should not use option #{$1}"
end end