Add Rubocop TODO list.

Library/.rubocop.yml

@@ -1,6 +1,9 @@
+inherit_from: .rubocop_todo.yml
+
 AllCops:
   TargetRubyVersion: 2.0
   Exclude:
+    - 'Homebrew/cask/**/*'
     - 'Homebrew/vendor/**/*'
     - 'Homebrew/test/vendor/**/*'
 

Library/.rubocop_todo.yml

@@ -0,0 +1,259 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-09-17 15:44:31 +0100 using RuboCop version 0.42.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
+# SupportedStyles: keyword, variable, start_of_line
+Lint/EndAlignment:
+  Exclude:
+    - 'Homebrew/download_strategy.rb'
+    - 'Homebrew/keg.rb'
+    - 'Homebrew/os/mac/cctools_mach.rb'
+
+# Offense count: 18
+Lint/HandleExceptions:
+  Exclude:
+    - 'Homebrew/cmd/install.rb'
+    - 'Homebrew/cmd/reinstall.rb'
+    - 'Homebrew/cmd/tap.rb'
+    - 'Homebrew/cmd/update-report.rb'
+    - 'Homebrew/cmd/upgrade.rb'
+    - 'Homebrew/cmd/uses.rb'
+    - 'Homebrew/descriptions.rb'
+    - 'Homebrew/dev-cmd/test-bot.rb'
+    - 'Homebrew/diagnostic.rb'
+    - 'Homebrew/extend/ENV/super.rb'
+    - 'Homebrew/extend/pathname.rb'
+    - 'Homebrew/formula.rb'
+    - 'Homebrew/formula_versions.rb'
+    - 'Homebrew/test/test_ENV.rb'
+
+# Offense count: 3
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'Homebrew/formula.rb'
+    - 'Homebrew/version.rb'
+
+# Offense count: 1
+Lint/Loop:
+  Exclude:
+    - 'Homebrew/patch.rb'
+
+# Offense count: 6
+Lint/NestedMethodDefinition:
+  Exclude:
+    - 'Homebrew/dev-cmd/bottle.rb'
+    - 'Homebrew/dev-cmd/test-bot.rb'
+
+# Offense count: 2
+Lint/NonLocalExitFromIterator:
+  Exclude:
+    - 'Homebrew/extend/pathname.rb'
+
+# Offense count: 28
+Lint/RescueException:
+  Enabled: false
+
+# Offense count: 1
+Lint/ShadowedException:
+  Exclude:
+    - 'Homebrew/brew.rb'
+
+# Offense count: 2
+Lint/UselessAssignment:
+  Exclude:
+    - 'Homebrew/requirements.rb'
+
+# Offense count: 18
+Metrics/BlockNesting:
+  Max: 5
+
+# Offense count: 20
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 369
+
+# Offense count: 1
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 6
+
+# Offense count: 2
+Performance/FixedSize:
+  Exclude:
+    - 'Homebrew/dev-cmd/audit.rb'
+    - 'Homebrew/dev-cmd/bottle.rb'
+
+# Offense count: 8
+Style/AccessorMethodName:
+  Exclude:
+    - 'Homebrew/download_strategy.rb'
+    - 'Homebrew/extend/ENV/std.rb'
+    - 'Homebrew/formula.rb'
+    - 'Homebrew/formula_lock.rb'
+    - 'Homebrew/formulary.rb'
+    - 'Homebrew/migrator.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: prefer_alias, prefer_alias_method
+Style/Alias:
+  Exclude:
+    - 'Homebrew/blacklist.rb'
+
+# Offense count: 26
+Style/CaseEquality:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
+# SupportedStyles: case, end
+Style/CaseIndentation:
+  Exclude:
+    - 'Homebrew/keg.rb'
+
+# Offense count: 11
+Style/ClassVars:
+  Exclude:
+    - 'Homebrew/cleanup.rb'
+    - 'Homebrew/dev-cmd/audit.rb'
+    - 'Homebrew/dev-cmd/test-bot.rb'
+    - 'Homebrew/formula_installer.rb'
+    - 'Homebrew/test/testing_env.rb'
+    - 'Homebrew/utils.rb'
+
+# Offense count: 1
+Style/ConstantName:
+  Exclude:
+    - 'Homebrew/os/mac.rb'
+
+# Offense count: 10
+Style/DoubleNegation:
+  Exclude:
+    - 'Homebrew/extend/ARGV.rb'
+    - 'Homebrew/formula_installer.rb'
+    - 'Homebrew/os/mac/cctools_keg.rb'
+    - 'Homebrew/os/mac/ruby_keg.rb'
+    - 'Homebrew/os/mac/xcode.rb'
+    - 'Homebrew/requirement.rb'
+    - 'Homebrew/software_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: format, sprintf, percent
+Style/FormatString:
+  Exclude:
+    - 'Homebrew/formula.rb'
+
+# Offense count: 13
+# Configuration parameters: AllowedVariables.
+Style/GlobalVars:
+  Exclude:
+    - 'Homebrew/diagnostic.rb'
+    - 'Homebrew/utils.rb'
+
+# Offense count: 2
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'Homebrew/formula_lock.rb'
+
+# Offense count: 5
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: snake_case, camelCase
+Style/MethodName:
+  Exclude:
+    - 'Homebrew/cleanup.rb'
+    - 'Homebrew/diagnostic.rb'
+    - 'Homebrew/formula_cellar_checks.rb'
+    - 'Homebrew/formula_installer.rb'
+    - 'Homebrew/os/mac/cctools_mach.rb'
+
+# Offense count: 7
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: module_function, extend_self
+Style/ModuleFunction:
+  Exclude:
+    - 'Homebrew/global.rb'
+    - 'Homebrew/os/mac.rb'
+    - 'Homebrew/os/mac/xcode.rb'
+    - 'Homebrew/os/mac/xquartz.rb'
+    - 'Homebrew/utils/github.rb'
+    - 'Homebrew/utils/json.rb'
+
+# Offense count: 8
+Style/MultilineBlockChain:
+  Exclude:
+    - 'Homebrew/cmd/search.rb'
+    - 'Homebrew/dev-cmd/aspell-dictionaries.rb'
+    - 'Homebrew/dev-cmd/audit.rb'
+    - 'Homebrew/dev-cmd/man.rb'
+    - 'Homebrew/diagnostic.rb'
+    - 'Homebrew/test/test_patching.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/MutableConstant:
+  Exclude:
+    - 'Homebrew/dependency_collector.rb'
+    - 'Homebrew/formulary.rb'
+    - 'Homebrew/tab.rb'
+    - 'Homebrew/tap.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
+# SupportedStyles: skip_modifier_ifs, always
+Style/Next:
+  Exclude:
+    - 'Homebrew/dev-cmd/test-bot.rb'
+
+# Offense count: 9
+Style/OpMethod:
+  Exclude:
+    - 'Homebrew/compilers.rb'
+    - 'Homebrew/dependencies.rb'
+    - 'Homebrew/install_renamed.rb'
+    - 'Homebrew/options.rb'
+
+# Offense count: 4
+# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
+# NamePrefix: is_, has_, have_
+# NamePrefixBlacklist: is_, has_, have_
+# NameWhitelist: is_a?
+Style/PredicateName:
+  Exclude:
+    - 'spec/**/*'
+    - 'Homebrew/download_strategy.rb'
+    - 'Homebrew/hardware.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'Homebrew/diagnostic.rb'
+    - 'Homebrew/keg.rb'
+    - 'Homebrew/version.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Exclude:
+    - 'Homebrew/descriptions.rb'
+
+# Offense count: 1
+# Configuration parameters: Methods.
+# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
+Style/SingleLineBlockParams:
+  Exclude:
+    - 'Homebrew/diagnostic.rb'