admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

readall: check for shadowed aliases.

Browse Source 
This will become particularly relevant when there’s a new version of a
formula and the existing alias needs to be removed.
This commit is contained in:
Mike McQuaid 2017-02-20 14:05:40 +00:00
parent 606790d062
commit 68bd744d0e
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Library/Homebrew/readall.rb
View File

@ -24,16 +24,15 @@ module Readall
!failed
end
def valid_aliases?(alias_dirs)
def valid_aliases?(alias_dir, formula_dir)
return false unless alias_dir.directory?
failed = false
alias_dirs.each do |alias_dir|
next unless alias_dir.directory?
alias_dir.children.each do |f|
next unless f.symlink?
next if f.file?
onoe "Broken alias: #{f}"
failed = true
end
alias_dir.each_child do |f|
next unless f.symlink?
next if f.file? && !(formula_dir/"#{f.basename}.rb").exist?
onoe "Broken alias: #{f}"
failed = true
end
!failed
end
@ -57,7 +56,7 @@ module Readall
def valid_tap?(tap, options = {})
failed = false
if options[:aliases]
valid_aliases = valid_aliases?([tap.alias_dir])
valid_aliases = valid_aliases?(tap.alias_dir, tap.formula_dir)
failed = true unless valid_aliases
end
valid_formulae = valid_formulae?(tap.formula_files)