admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #6130 from jonchang/audit-accelerate

Browse Source 
audit: check Accelerate linkage for core formulae
This commit is contained in:
Mike McQuaid 2019-05-14 08:21:14 +01:00 committed by GitHub
commit 66dfd8ceb0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
View File

@ -48,6 +48,26 @@ module FormulaCellarChecks
EOS
end
def check_accelerate_framework_links
return unless @core_tap
return unless formula.prefix.directory?
keg = Keg.new(formula.prefix)
system_accelerate = keg.mach_o_files.select do |obj|
dlls = obj.dynamically_linked_libraries
dlls.any? { |dll| %r{^/System/Library/Frameworks/Accelerate.framework}.match dll }
end
return if system_accelerate.empty?
<<~EOS
object files were linked against system Accelerate
These object files were linked against the outdated system Accelerate framework.
Core tap formulae should link against OpenBLAS instead.
Adding `depends_on "openblas"` to the formula may help.
#{system_accelerate * "\n "}
EOS
end
def check_python_framework_links(lib)
python_modules = Pathname.glob lib/"python*/site-packages/**/*.so"
framework_links = python_modules.select do |obj|
@ -95,6 +115,7 @@ module FormulaCellarChecks
generic_audit_installed
problem_if_output(check_shadowed_headers)
problem_if_output(check_openssl_links)
problem_if_output(check_accelerate_framework_links)
problem_if_output(check_python_framework_links(formula.lib))
check_linkage
end