admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add type signatures for Cask::Staged.

Browse Source
This commit is contained in:
Markus Reiter 2020-11-17 03:08:13 +01:00
parent 64a0e9a721
commit 66bf1314a1
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
Library/Homebrew/cask/staged.rb
View File

@ -1,4 +1,4 @@
# typed: false # typed: true
# frozen_string_literal: true # frozen_string_literal: true
require "utils/user" require "utils/user"
@ -8,25 +8,35 @@ module Cask
# #
# @api private # @api private
module Staged module Staged
extend T::Sig
# FIXME: Enable cop again when https://github.com/sorbet/sorbet/issues/3532 is fixed.
# rubocop:disable Style/MutableConstant
Paths = T.type_alias { T.any(String, Pathname, T::Array[T.any(String, Pathname)]) }
# rubocop:enable Style/MutableConstant
sig { params(paths: Paths, permissions_str: String).void }
def set_permissions(paths, permissions_str) def set_permissions(paths, permissions_str)
full_paths = remove_nonexistent(paths) full_paths = remove_nonexistent(paths)
return if full_paths.empty? return if full_paths.empty?
@command.run!("/bin/chmod", args: ["-R", "--", permissions_str] + full_paths, @command.run!("/bin/chmod", args: ["-R", "--", permissions_str, *full_paths],
sudo: false) sudo: false)
end end
def set_ownership(paths, user: User.current, group: "staff") sig { params(paths: Paths, user: T.any(String, User), group: String).void }
def set_ownership(paths, user: T.must(User.current), group: "staff")
full_paths = remove_nonexistent(paths) full_paths = remove_nonexistent(paths)
return if full_paths.empty? return if full_paths.empty?
ohai "Changing ownership of paths required by #{@cask}; your password may be necessary" ohai "Changing ownership of paths required by #{@cask}; your password may be necessary"
@command.run!("/usr/sbin/chown", args: ["-R", "--", "#{user}:#{group}"] + full_paths, @command.run!("/usr/sbin/chown", args: ["-R", "--", "#{user}:#{group}", *full_paths],
sudo: true) sudo: true)
end end
private private
sig { params(paths: Paths).returns(T::Array[Pathname]) }
def remove_nonexistent(paths) def remove_nonexistent(paths)
Array(paths).map { |p| Pathname(p).expand_path }.select(&:exist?) Array(paths).map { |p| Pathname(p).expand_path }.select(&:exist?)
end end

7
Library/Homebrew/cask/staged.rbi Normal file
View File

@ -0,0 +1,7 @@
# typed: strict
module Cask
module Staged
include Kernel
end
end