admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

test-bot: separate tap/core no formula handling.

Browse Source 
`e.tap` calls the tap method which wants a block on
`FormulaUnavailableError` so the previous approach is 👎.
This commit is contained in:
Mike McQuaid 2016-09-07 12:47:21 +01:00
parent f9fe5b6798
commit 665c56538e
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
Library/Homebrew/dev-cmd/test-bot.rb
View File

@ -247,10 +247,15 @@ module Homebrew
def safe_formula_canonical_name(formula_name) def safe_formula_canonical_name(formula_name)
Formulary.factory(formula_name).full_name Formulary.factory(formula_name).full_name
rescue TapFormulaUnavailableError, FormulaUnavailableError => e rescue TapFormulaUnavailableError => e
exception_tap = e.tap || CoreTap.instance raise if e.tap.installed?
raise if exception_tap.installed? test "brew", "tap", e.tap.name
test "brew", "tap", exception_tap.name retry unless steps.last.failed?
onoe e
puts e.backtrace
rescue FormulaUnavailableError => e
raise if CoreTap.instance.installed?
test "brew", "tap", CoreTap.instance.name
retry unless steps.last.failed? retry unless steps.last.failed?
onoe e onoe e
puts e.backtrace puts e.backtrace