From 665b6ca5c5beb766193bdd0a44e4b0099a52cdee Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Thu, 25 Aug 2022 23:16:26 +0800 Subject: [PATCH] formula_auditor: require `--git` only if not `--strict` The Git log is required only when `--strict` is not passed. This check should still run with one of `--strict` or `--git`, but currently passing `--strict` also requires `--git` in order to run this check. This will still not be done during `tap_syntax` jobs after this change. --- Library/Homebrew/formula_auditor.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Library/Homebrew/formula_auditor.rb b/Library/Homebrew/formula_auditor.rb index 622b2dadb2..75f681d160 100644 --- a/Library/Homebrew/formula_auditor.rb +++ b/Library/Homebrew/formula_auditor.rb @@ -406,9 +406,8 @@ module Homebrew end def audit_gcc_dependency - return unless @git return unless @core_tap - return if !@strict && !formula.tap.git? # git log is required for non-strict audit + return if !@strict && !@git && !formula.tap.git? # git log is required for non-strict audit return unless Homebrew::SimulateSystem.simulating_or_running_on_linux? return unless linux_only_gcc_dep?(formula)