From 6597ee6fd3a21a20f6f96d5e0d3a63745dc989c5 Mon Sep 17 00:00:00 2001 From: Sam Ford <1584702+samford@users.noreply.github.com> Date: Sat, 29 Apr 2023 00:23:41 -0400 Subject: [PATCH] Sparkle: Account for nil content value `content` can be `nil` when a request doesn't succeed but `#versions_from_content` expects a `String` value, so we need to guard against a `nil` value like we do in other strategies. --- Library/Homebrew/livecheck/strategy/sparkle.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Library/Homebrew/livecheck/strategy/sparkle.rb b/Library/Homebrew/livecheck/strategy/sparkle.rb index 03a34676e8..4fc45aa2c7 100644 --- a/Library/Homebrew/livecheck/strategy/sparkle.rb +++ b/Library/Homebrew/livecheck/strategy/sparkle.rb @@ -190,6 +190,7 @@ module Homebrew match_data.merge!(Strategy.page_content(url)) content = match_data.delete(:content) + return match_data if content.blank? versions_from_content(content, regex, &block).each do |version_text| match_data[:matches][version_text] = Version.new(version_text)