admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #18217 from samford/adjust-typing-around-check_pull_requests

Browse Source
This commit is contained in:
Carlo Cabrera 2024-09-01 04:57:39 +08:00 committed by GitHub
commit 64e0c58c5c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/dev-cmd/bump-formula-pr.rb
View File

@ -467,7 +467,7 @@ module Homebrew
sig { sig {
params(formula: Formula, tap_remote_repo: String, state: T.nilable(String), params(formula: Formula, tap_remote_repo: String, state: T.nilable(String),
version: T.nilable(String)).returns(T.nilable(T::Array[String])) version: T.nilable(String)).void
} }
def check_pull_requests(formula, tap_remote_repo, state: nil, version: nil) def check_pull_requests(formula, tap_remote_repo, state: nil, version: nil)
tap = formula.tap tap = formula.tap

12
Library/Homebrew/utils/github.rb
View File

@ -629,7 +629,17 @@ module GitHub
pull_requests || [] pull_requests || []
end end
def self.check_for_duplicate_pull_requests(name, tap_remote_repo, file:, quiet:, state: nil, version: nil) sig {
params(
name: String,
tap_remote_repo: String,
file: String,
quiet: T::Boolean,
state: T.nilable(String),
version: T.nilable(String),
).void
}
def self.check_for_duplicate_pull_requests(name, tap_remote_repo, file:, quiet: false, state: nil, version: nil)
pull_requests = fetch_pull_requests(name, tap_remote_repo, state:, version:) pull_requests = fetch_pull_requests(name, tap_remote_repo, state:, version:)
pull_requests.select! do |pr| pull_requests.select! do |pr|