From 648c50e9a6ae4d26cb2e92064667cabee1be04fe Mon Sep 17 00:00:00 2001 From: apainintheneck Date: Sat, 3 Feb 2024 15:06:30 -0800 Subject: [PATCH] rubocop: exclude more tap files from the top-level method cop Basically, this started failing for me on my personal tap because there are some methods defined at the top-level in my Rakefile. That seems acceptable to me and since we're already ignoring all other Ruby files in the tap I figured we might as well just ignore all of them. I ended up changing one other use of `Taps/**/*.rb` to `Taps/**/*.rb` as well. --- Library/.rubocop.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 804ff34fe2..b4155bad99 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -373,7 +373,7 @@ Style/NumericLiterals: Style/OpenStructUse: Exclude: - - "Taps/**/*.rb" + - "Taps/**/*" # TODO: This is a pre-existing violation and should be corrected # to define methods so that call sites can be type-checked. - "Homebrew/cli/args.rb" @@ -426,7 +426,7 @@ Style/TernaryParentheses: Style/TopLevelMethodDefinition: Enabled: true Exclude: - - "Taps/**/*.rb" + - "Taps/**/*" # Trailing commas make diffs nicer. Style/TrailingCommaInArguments: