admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

add dry-run option to formula#install

Browse Source
This commit is contained in:
hyuraku 2022-08-16 20:59:01 +09:00
parent 93ebe42a72
commit 634fcad1b2
4 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/install.rb
View File

@ -245,6 +245,7 @@ module Homebrew
debug: args.debug?, debug: args.debug?,
quiet: args.quiet?, quiet: args.quiet?,
verbose: args.verbose?, verbose: args.verbose?,
dry_run: args.dry_run?,
) )
Upgrade.check_installed_dependents( Upgrade.check_installed_dependents(
@ -260,9 +261,10 @@ module Homebrew
debug: args.debug?, debug: args.debug?,
quiet: args.quiet?, quiet: args.quiet?,
verbose: args.verbose?, verbose: args.verbose?,
dry_run: args.dry_run?,
) )
Cleanup.periodic_clean! Cleanup.periodic_clean!(dry_run: args.dry_run?)
Homebrew.messages.display_messages(display_times: args.display_times?) Homebrew.messages.display_messages(display_times: args.display_times?)
rescue FormulaUnreadableError, FormulaClassUnavailableError, rescue FormulaUnreadableError, FormulaClassUnavailableError,

11
Library/Homebrew/formula_installer.rb
View File

@ -40,7 +40,7 @@ class FormulaInstaller
attr_predicate :show_summary_heading?, :show_header? attr_predicate :show_summary_heading?, :show_header?
attr_predicate :force_bottle?, :ignore_deps?, :only_deps?, :interactive?, :git?, :force?, :overwrite?, :keep_tmp? attr_predicate :force_bottle?, :ignore_deps?, :only_deps?, :interactive?, :git?, :force?, :overwrite?, :keep_tmp?
attr_predicate :debug_symbols? attr_predicate :debug_symbols?
attr_predicate :verbose?, :debug?, :quiet? attr_predicate :verbose?, :debug?, :quiet?, :dry_run?
def initialize( def initialize(
formula, formula,
@ -66,7 +66,8 @@ class FormulaInstaller
overwrite: false, overwrite: false,
debug: false, debug: false,
quiet: false, quiet: false,
verbose: false verbose: false,
dry_run: false
) )
@formula = formula @formula = formula
@env = env @env = env
@ -90,6 +91,7 @@ class FormulaInstaller
@verbose = verbose @verbose = verbose
@quiet = quiet @quiet = quiet
@debug = debug @debug = debug
@dry_run = dry_run
@installed_as_dependency = installed_as_dependency @installed_as_dependency = installed_as_dependency
@installed_on_request = installed_on_request @installed_on_request = installed_on_request
@options = options @options = options
@ -696,6 +698,7 @@ class FormulaInstaller
debug: debug?, debug: debug?,
quiet: quiet?, quiet: quiet?,
verbose: verbose?, verbose: verbose?,
dry_run: dry_run?,
) )
fi.prelude fi.prelude
fi.fetch fi.fetch
@ -1182,6 +1185,10 @@ class FormulaInstaller
return if self.class.fetched.include?(formula) return if self.class.fetched.include?(formula)
fetch_dependencies fetch_dependencies
if dry_run?
puts "#{Formatter.identifier(formula.full_name)} would be installed"
return
end
return if only_deps? return if only_deps?

4
Library/Homebrew/install.rb
View File

@ -274,7 +274,8 @@ module Homebrew
overwrite: false, overwrite: false,
debug: false, debug: false,
quiet: false, quiet: false,
verbose: false verbose: false,
dry_run: false
) )
formula_installers = formulae_to_install.map do |f| formula_installers = formulae_to_install.map do |f|
Migrator.migrate_if_needed(f, force: force) Migrator.migrate_if_needed(f, force: force)
@ -300,6 +301,7 @@ module Homebrew
debug: debug, debug: debug,
quiet: quiet, quiet: quiet,
verbose: verbose, verbose: verbose,
dry_run: dry_run,
) )
begin begin

1
Library/Homebrew/upgrade.rb
View File

@ -208,6 +208,7 @@ module Homebrew
# possible for the existing build to interfere with the build we are about to # possible for the existing build to interfere with the build we are about to
# do! Seriously, it happens! # do! Seriously, it happens!
kegs.each(&:unlink) if kegs.present? kegs.each(&:unlink) if kegs.present?
return if formula_installer.dry_run?
formula_installer.install formula_installer.install
formula_installer.finish formula_installer.finish