audit: Add more tests for FormulaAudit/Miscellaneous cop
This commit is contained in:
		
							parent
							
								
									dbc4a385b9
								
							
						
					
					
						commit
						626cb6ca91
					
				@ -380,6 +380,21 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
 | 
				
			|||||||
      end
 | 
					      end
 | 
				
			||||||
    end
 | 
					    end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    it "with build.universal? exempted formula" do
 | 
				
			||||||
 | 
					      source = <<-EOS.undent
 | 
				
			||||||
 | 
					        class Wine < Formula
 | 
				
			||||||
 | 
					          desc "foo"
 | 
				
			||||||
 | 
					          url 'http://example.com/foo-1.0.tgz'
 | 
				
			||||||
 | 
					          if build.universal?
 | 
				
			||||||
 | 
					             "foo"
 | 
				
			||||||
 | 
					          end
 | 
				
			||||||
 | 
					        end
 | 
				
			||||||
 | 
					      EOS
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					      inspect_source(cop, source, "/homebrew-core/Formula/wine.rb")
 | 
				
			||||||
 | 
					      expect(cop.offenses).to eq([])
 | 
				
			||||||
 | 
					    end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    it "with ENV.universal_binary" do
 | 
					    it "with ENV.universal_binary" do
 | 
				
			||||||
      source = <<-EOS.undent
 | 
					      source = <<-EOS.undent
 | 
				
			||||||
        class Foo < Formula
 | 
					        class Foo < Formula
 | 
				
			||||||
@ -450,6 +465,19 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
 | 
				
			|||||||
      end
 | 
					      end
 | 
				
			||||||
    end
 | 
					    end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    it "with ruby-macho alternatives audit exempted formula" do
 | 
				
			||||||
 | 
					      source = <<-EOS.undent
 | 
				
			||||||
 | 
					        class Cctools < Formula
 | 
				
			||||||
 | 
					          desc "foo"
 | 
				
			||||||
 | 
					          url 'http://example.com/foo-1.0.tgz'
 | 
				
			||||||
 | 
					          system "install_name_tool", "-id"
 | 
				
			||||||
 | 
					        end
 | 
				
			||||||
 | 
					      EOS
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					      inspect_source(cop, source, "/homebrew-core/Formula/cctools.rb")
 | 
				
			||||||
 | 
					      expect(cop.offenses).to eq([])
 | 
				
			||||||
 | 
					    end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    it "with npm install without language::Node args" do
 | 
					    it "with npm install without language::Node args" do
 | 
				
			||||||
      source = <<-EOS.undent
 | 
					      source = <<-EOS.undent
 | 
				
			||||||
        class Foo < Formula
 | 
					        class Foo < Formula
 | 
				
			||||||
@ -471,5 +499,18 @@ describe RuboCop::Cop::FormulaAudit::Miscellaneous do
 | 
				
			|||||||
        expect_offense(expected, actual)
 | 
					        expect_offense(expected, actual)
 | 
				
			||||||
      end
 | 
					      end
 | 
				
			||||||
    end
 | 
					    end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    it "with npm install without language::Node args in kibana" do
 | 
				
			||||||
 | 
					      source = <<-EOS.undent
 | 
				
			||||||
 | 
					        class KibanaAT44 < Formula
 | 
				
			||||||
 | 
					          desc "foo"
 | 
				
			||||||
 | 
					          url 'http://example.com/foo-1.0.tgz'
 | 
				
			||||||
 | 
					          system "npm", "install"
 | 
				
			||||||
 | 
					        end
 | 
				
			||||||
 | 
					      EOS
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					      inspect_source(cop, source, "/homebrew-core/Formula/kibana@4.4.rb")
 | 
				
			||||||
 | 
					      expect(cop.offenses).to eq([])
 | 
				
			||||||
 | 
					    end
 | 
				
			||||||
  end
 | 
					  end
 | 
				
			||||||
end
 | 
					end
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user