From df5aac8b092f6552b065aa68c09e034b3e5e71e0 Mon Sep 17 00:00:00 2001 From: Rylan Polster Date: Fri, 31 Jul 2020 21:32:36 -0400 Subject: [PATCH 1/4] docs: add license information --- docs/Formula-Cookbook.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/docs/Formula-Cookbook.md b/docs/Formula-Cookbook.md index 19f38b0a2e..630d427ab7 100644 --- a/docs/Formula-Cookbook.md +++ b/docs/Formula-Cookbook.md @@ -54,6 +54,7 @@ class Foo < Formula homepage "" url "https://example.com/foo-0.1.tar.gz" sha256 "85cc828a96735bdafcf29eb6291ca91bac846579bcef7308536e0c875d6c81d7" + license "" # depends_on "cmake" => :build @@ -86,6 +87,20 @@ An SSL/TLS (https) [`homepage`](https://rubydoc.brew.sh/Formula#homepage%3D-clas Try to summarise from the [`homepage`](https://rubydoc.brew.sh/Formula#homepage%3D-class_method) what the formula does in the [`desc`](https://rubydoc.brew.sh/Formula#desc%3D-class_method)ription. Note that the [`desc`](https://rubydoc.brew.sh/Formula#desc%3D-class_method)ription is automatically prepended with the formula name. +### Fill in the `license` + +**We don’t accept formulae without a [`license`](https://rubydoc.brew.sh/Formula#license-class_method)!** + +Find the license identifier from the [SPDX License List](https://spdx.org/licenses/). Note that we don't accept licenses that don't appear on the list. + +If the formula gives the user the option to choose which license to use, you should list them all in an array: + +```ruby +license ["MIT", "GPL-2.0"] +``` + +Note: only specify multiple licenses if the formula gives the user a choice between the licenses. Formulae that have different licenses for different parts of their software should specify only the more restrictive license. + ### Check the build system ```sh From 7fe6384ca5ca1ff4c73a852bd3281ecabfc3afd7 Mon Sep 17 00:00:00 2001 From: Rylan Polster Date: Sat, 1 Aug 2020 13:39:08 -0400 Subject: [PATCH 2/4] Improve wording Co-authored-by: Adrian Ho --- docs/Formula-Cookbook.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Formula-Cookbook.md b/docs/Formula-Cookbook.md index 630d427ab7..c1f85ee7bb 100644 --- a/docs/Formula-Cookbook.md +++ b/docs/Formula-Cookbook.md @@ -91,7 +91,7 @@ Try to summarise from the [`homepage`](https://rubydoc.brew.sh/Formula#homepage% **We don’t accept formulae without a [`license`](https://rubydoc.brew.sh/Formula#license-class_method)!** -Find the license identifier from the [SPDX License List](https://spdx.org/licenses/). Note that we don't accept licenses that don't appear on the list. +Find the license identifier from the [SPDX License List](https://spdx.org/licenses/). We only accept licenses from this list. If the formula gives the user the option to choose which license to use, you should list them all in an array: From 7c6cd247ee8f1eae426ba61c7bfa9ea3b4c91a33 Mon Sep 17 00:00:00 2001 From: Rylan Polster Date: Mon, 3 Aug 2020 10:10:17 -0400 Subject: [PATCH 3/4] Apply suggestions from code review Co-authored-by: Mike McQuaid --- docs/Formula-Cookbook.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/Formula-Cookbook.md b/docs/Formula-Cookbook.md index c1f85ee7bb..66b86634d0 100644 --- a/docs/Formula-Cookbook.md +++ b/docs/Formula-Cookbook.md @@ -89,11 +89,11 @@ Try to summarise from the [`homepage`](https://rubydoc.brew.sh/Formula#homepage% ### Fill in the `license` -**We don’t accept formulae without a [`license`](https://rubydoc.brew.sh/Formula#license-class_method)!** +**We don’t accept new formulae into Homebrew/homebrew-core without a [`license`](https://rubydoc.brew.sh/Formula#license-class_method)!** -Find the license identifier from the [SPDX License List](https://spdx.org/licenses/). We only accept licenses from this list. +Find the license identifier from the [SPDX License List](https://spdx.org/licenses/). We only accept licenses from this list that are a [Debian Free Software Guidelines license](https://wiki.debian.org/DFSGLicenses). -If the formula gives the user the option to choose which license to use, you should list them all in an array: +If the software is available under multiple licenses, you should list them all in an array: ```ruby license ["MIT", "GPL-2.0"] From 1173d00bf6316fa4ce98a46a1fcbe9d120d75dcc Mon Sep 17 00:00:00 2001 From: Rylan Polster Date: Mon, 3 Aug 2020 10:14:01 -0400 Subject: [PATCH 4/4] Add links for determining more restrictive license --- docs/Formula-Cookbook.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Formula-Cookbook.md b/docs/Formula-Cookbook.md index 66b86634d0..891c484824 100644 --- a/docs/Formula-Cookbook.md +++ b/docs/Formula-Cookbook.md @@ -99,7 +99,7 @@ If the software is available under multiple licenses, you should list them all i license ["MIT", "GPL-2.0"] ``` -Note: only specify multiple licenses if the formula gives the user a choice between the licenses. Formulae that have different licenses for different parts of their software should specify only the more restrictive license. +Note: only specify multiple licenses if the formula gives the user a choice between the licenses. Formulae that have different licenses for different parts of their software should specify only the more restrictive license. For help determining which license is more restrictive, take a look [https://choosealicense.com](https://choosealicense.com/licenses/) or the [Comparison of free and open-source software licences Wikipedia page](https://en.wikipedia.org/wiki/Comparison_of_free_and_open-source_software_licences). ### Check the build system