From 61e08e4b41ee37890bf2ec7f5de32080d2b9c2ef Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Mon, 8 Sep 2025 09:10:13 -0700 Subject: [PATCH] Fix type errors --- Library/Homebrew/cask/tab.rb | 2 +- Library/Homebrew/system_command.rb | 8 ++++---- Library/Homebrew/tab.rb | 1 + 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/cask/tab.rb b/Library/Homebrew/cask/tab.rb index 6ba4b027d7..d9804fa70c 100644 --- a/Library/Homebrew/cask/tab.rb +++ b/Library/Homebrew/cask/tab.rb @@ -11,7 +11,7 @@ module Cask sig { returns(T.nilable(T::Array[T.untyped])) } attr_accessor :uninstall_artifacts - sig { params(attributes: T::Hash[T.any(String, Symbol), T.untyped]).void } + sig { params(attributes: T.any(T::Hash[String, T.untyped], T::Hash[Symbol, T.untyped])).void } def initialize(attributes = {}) @uninstall_flight_blocks = T.let(nil, T.nilable(T::Boolean)) @uninstall_artifacts = T.let(nil, T.nilable(T::Array[T.untyped])) diff --git a/Library/Homebrew/system_command.rb b/Library/Homebrew/system_command.rb index bac03b52d4..3f6f6fc230 100644 --- a/Library/Homebrew/system_command.rb +++ b/Library/Homebrew/system_command.rb @@ -27,7 +27,7 @@ class SystemCommand args: T::Array[T.any(String, Integer, Float, Pathname, URI::Generic)], sudo: T::Boolean, sudo_as_root: T::Boolean, - env: T::Hash[String, String], + env: T::Hash[String, T.any(NilClass, String, T::Boolean)], input: T.any(String, T::Array[String]), must_succeed: T::Boolean, print_stdout: T.any(T::Boolean, Symbol), @@ -56,7 +56,7 @@ class SystemCommand args: T::Array[T.any(String, Integer, Float, Pathname, URI::Generic)], sudo: T::Boolean, sudo_as_root: T::Boolean, - env: T::Hash[String, String], + env: T::Hash[String, T.any(NilClass, String, T::Boolean)], input: T.any(String, T::Array[String]), print_stdout: T.any(T::Boolean, Symbol), print_stderr: T.any(T::Boolean, Symbol), @@ -84,7 +84,7 @@ class SystemCommand args: T::Array[T.any(String, Integer, Float, Pathname, URI::Generic)], sudo: T::Boolean, sudo_as_root: T::Boolean, - env: T::Hash[String, String], + env: T::Hash[String, T.any(NilClass, String, T::Boolean)], input: T.any(String, T::Array[String]), must_succeed: T::Boolean, print_stdout: T.any(T::Boolean, Symbol), @@ -110,7 +110,7 @@ class SystemCommand args: T::Array[T.any(String, Integer, Float, Pathname, URI::Generic)], sudo: T::Boolean, sudo_as_root: T::Boolean, - env: T::Hash[String, String], + env: T::Hash[String, T.any(NilClass, String, T::Boolean)], input: T.any(String, T::Array[String]), must_succeed: T::Boolean, print_stdout: T.any(T::Boolean, Symbol), diff --git a/Library/Homebrew/tab.rb b/Library/Homebrew/tab.rb index 5e8149e755..15b5b0ae21 100644 --- a/Library/Homebrew/tab.rb +++ b/Library/Homebrew/tab.rb @@ -38,6 +38,7 @@ class AbstractTab # @api internal attr_accessor :runtime_dependencies + # TODO: Update attributes to only accept symbol keys (kwargs style). sig { params(attributes: T.any(T::Hash[String, T.untyped], T::Hash[Symbol, T.untyped])).void } def initialize(attributes = {}) @installed_as_dependency = T.let(nil, T.nilable(T::Boolean))