From 60f23778533100997715e2dd52a400a50a62e8ca Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Sun, 24 May 2015 03:05:00 +0800 Subject: [PATCH] audit: formula version string should have digit Closes Homebrew/homebrew#40025. Signed-off-by: Xu Cheng --- Library/Homebrew/cmd/audit.rb | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index be6be5c39c..7d0230ab21 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -350,6 +350,14 @@ class FormulaAuditor spec.patches.select(&:external?).each { |p| audit_patch(p) } end + %w[Stable Devel].each do |name| + next unless spec = formula.send(name.downcase) + version = spec.version + if version.to_s !~ /\d/ + problem "#{name}: version (#{version}) is set to a string without a digit" + end + end + if formula.stable && formula.devel if formula.devel.version < formula.stable.version problem "devel version #{formula.devel.version} is older than stable version #{formula.stable.version}"